Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2058613002: Move WTF string to number converter functions to StringToNumber.h (Closed)

Created:
4 years, 6 months ago by esprehn
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-wtf_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, eric.carlson_apple.com, fs, gavinp+prerender_chromium.org, gasubic, kenneth.christiansen, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, Mikhail, mkwst+watchlist-csp_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, nessy, vcarbune.chromium, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WTF string to number converter functions to StringToNumber.h This allows various things to call these methods without having to depend on the WTFString.h header which was a strange place for a bunch of functions that take LChar* and UChar*'s. No functional changes are made, the code is just moved around. BUG=615174 Committed: https://crrev.com/7dc7c0fc073b84f3050726b52ceec1bbcb304ba3 Cr-Commit-Position: refs/heads/master@{#399095}

Patch Set 1 #

Patch Set 2 : missing files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -314 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizerInputStream.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDimension.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFontElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTScanner.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/wtf/text/StringToNumber.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/wtf/text/StringToNumber.cpp View 1 1 chunk +282 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 2 chunks +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +0 lines, -271 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058613002/20001
4 years, 6 months ago (2016-06-09 23:58:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
4 years, 6 months ago (2016-06-10 02:01:28 UTC) #6
esprehn
4 years, 6 months ago (2016-06-10 02:22:28 UTC) #8
Yuta Kitamura
lgtm
4 years, 6 months ago (2016-06-10 03:50:49 UTC) #9
haraken
LGTM
4 years, 6 months ago (2016-06-10 03:56:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058613002/20001
4 years, 6 months ago (2016-06-10 04:23:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 04:36:12 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 04:36:24 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 04:37:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7dc7c0fc073b84f3050726b52ceec1bbcb304ba3
Cr-Commit-Position: refs/heads/master@{#399095}

Powered by Google App Engine
This is Rietveld 408576698