Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2058573003: Remove the milo/buildbot backfiller (Closed)

Created:
4 years, 6 months ago by Ryan Tseng
Modified:
4 years, 6 months ago
Reviewers:
estaab, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Remove the milo/buildbot backfiller All buildbot backfilling has been superceeded by the pubsub handler. BUG= Committed: https://github.com/luci/luci-go/commit/f8162035637c7b3b0aa026b8fe737ae1ffd17aa8

Patch Set 1 #

Patch Set 2 : Also the buildbot collector #

Total comments: 2

Patch Set 3 : Recover the git portions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -313 lines) Patch
D appengine/cmd/milo/cmd/backfill/README.md View 1 2 1 chunk +1 line, -12 lines 0 comments Download
D appengine/cmd/milo/cmd/backfill/main.go View 1 2 3 chunks +0 lines, -46 lines 0 comments Download
D appengine/cmd/milo/collectors/buildbot/collector.go View 1 1 chunk +0 lines, -255 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058573003/1
4 years, 6 months ago (2016-06-10 00:41:02 UTC) #2
Ryan Tseng
afaict we don't need this anymore, right?
4 years, 6 months ago (2016-06-10 00:42:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058573003/20001
4 years, 6 months ago (2016-06-10 00:49:21 UTC) #6
estaab
https://codereview.chromium.org/2058573003/diff/20001/appengine/cmd/milo/cmd/backfill/main.go File appengine/cmd/milo/cmd/backfill/main.go (left): https://codereview.chromium.org/2058573003/diff/20001/appengine/cmd/milo/cmd/backfill/main.go#oldcode102 appengine/cmd/milo/cmd/backfill/main.go:102: ShortDesc: "runs the local git backfiller", Hmm, I'm still ...
4 years, 6 months ago (2016-06-10 01:04:46 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058573003/40001
4 years, 6 months ago (2016-06-10 01:12:23 UTC) #9
Ryan Tseng
https://codereview.chromium.org/2058573003/diff/20001/appengine/cmd/milo/cmd/backfill/main.go File appengine/cmd/milo/cmd/backfill/main.go (left): https://codereview.chromium.org/2058573003/diff/20001/appengine/cmd/milo/cmd/backfill/main.go#oldcode102 appengine/cmd/milo/cmd/backfill/main.go:102: ShortDesc: "runs the local git backfiller", On 2016/06/10 01:04:46, ...
4 years, 6 months ago (2016-06-10 01:12:44 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 03:14:33 UTC) #12
estaab
lgtm
4 years, 6 months ago (2016-06-10 03:39:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058573003/40001
4 years, 6 months ago (2016-06-10 17:27:32 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 17:30:30 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/f8162035637c7b3b0aa026b8fe737ae1ffd17aa8

Powered by Google App Engine
This is Rietveld 408576698