Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2058543002: Updating initial zoom level for remote connections in Android Client. (Closed)

Created:
4 years, 6 months ago by joedow
Modified:
4 years, 6 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating initial zoom level for remote connections in Android Client. This change updates the method used for sizing the remote desktop image to the Android device's screen. The previous method was to scale down the remote image so that the entire image would fit. This worked great for similarly sized displays but not so great for high resolution or multi-monitor displays. The method I use now is to scale up the remote image (if needed) such that there isn't any empty space on the screen. I do this by calculating the width and height ratios and scaling the image by the larger of the two. This ensures that the local screen is filled with the image of the remote display and is similar to the behavior that existed prior to my last change. The viewport is then translated to the upper left of the screen for the default starting position. Once the image is resized and positioned, I update starting coordinates for the cursor so it is placed in the center of the viewport area. BUG=618385 Committed: https://crrev.com/b144cbc55799ed4e4105ea21f030d51e9897a715 Cr-Commit-Position: refs/heads/master@{#399103}

Patch Set 1 #

Patch Set 2 : Cleaning up some logic in the handler class. #

Total comments: 2

Patch Set 3 : Addressing CR Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java View 1 2 2 chunks +8 lines, -21 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java View 1 1 chunk +12 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
joedow
PTAL! Thanks, Joe
4 years, 6 months ago (2016-06-09 23:35:12 UTC) #2
Lambros
lgtm https://codereview.chromium.org/2058543002/diff/20001/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java (right): https://codereview.chromium.org/2058543002/diff/20001/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java#newcode105 remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:105: // If the image is smaller than the ...
4 years, 6 months ago (2016-06-10 01:01:51 UTC) #3
joedow
Thanks! https://codereview.chromium.org/2058543002/diff/20001/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java File remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java (right): https://codereview.chromium.org/2058543002/diff/20001/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java#newcode105 remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java:105: // If the image is smaller than the ...
4 years, 6 months ago (2016-06-10 03:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058543002/40001
4 years, 6 months ago (2016-06-10 03:47:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-10 05:01:58 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 05:03:47 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b144cbc55799ed4e4105ea21f030d51e9897a715
Cr-Commit-Position: refs/heads/master@{#399103}

Powered by Google App Engine
This is Rietveld 408576698