Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2058533002: Expand filesystem_mock_unittest.py (add more test methods, change quick_check). (Closed)

Created:
4 years, 6 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
prasadv, raikiri
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand filesystem_mock_unittest.py (add more test methods, change quick_check). Committed: https://crrev.com/6c4accb31eecf1b3e7988ebc79870d0a8f264624 Cr-Commit-Position: refs/heads/master@{#400594}

Patch Set 1 #

Patch Set 2 : Re-add dummy test_relpath_win32 with comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -32 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py View 1 2 chunks +59 lines, -32 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
qyearsley
The purpose of this CL is just to improve this unit test a little. Note, ...
4 years, 6 months ago (2016-06-09 21:56:11 UTC) #2
qyearsley
4 years, 6 months ago (2016-06-09 21:56:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058533002/1
4 years, 6 months ago (2016-06-13 23:12:38 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238463)
4 years, 6 months ago (2016-06-14 00:55:25 UTC) #7
prasadv
lgtm
4 years, 6 months ago (2016-06-17 21:07:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058533002/1
4 years, 6 months ago (2016-06-17 21:17:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241171)
4 years, 6 months ago (2016-06-18 00:15:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058533002/20001
4 years, 6 months ago (2016-06-18 17:09:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-18 19:17:25 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 19:19:38 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c4accb31eecf1b3e7988ebc79870d0a8f264624
Cr-Commit-Position: refs/heads/master@{#400594}

Powered by Google App Engine
This is Rietveld 408576698