Oilpan: Prepare to move InspectorDatabaseResource to Oilpan heap.

Oilpan: Prepare to move InspectorDatabaseResource to Oilpan heap.

BUG=347902
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169623

[tkent, 2014-03-20 01:13:34]

A simple CL :-)

[haraken, 2014-03-20 04:42:58]

LGTM with comments.

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
File Source/modules/webdatabase/InspectorDatabaseAgent.h (right):

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
Source/modules/webdatabase/InspectorDatabaseAgent.h:78: typedef
PersistentHeapHashMap<String, RefPtrWillBeMember<InspectorDatabaseResource> >
DatabaseResourcesHeapMap;

This should be WillBePersistentHeapHashMap.

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
File Source/modules/webdatabase/InspectorDatabaseResource.h (right):

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
Source/modules/webdatabase/InspectorDatabaseResource.h:45: class
InspectorDatabaseResource : public
RefCountedWillBeGarbageCollected<InspectorDatabaseResource> {

This should be RefCountedWillBeGarbageCollectedFinalized because Strings need
destructors.

[tkent, 2014-03-20 05:07:56]

A simple CL had two errors!

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
File Source/modules/webdatabase/InspectorDatabaseAgent.h (right):

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
Source/modules/webdatabase/InspectorDatabaseAgent.h:78: typedef
PersistentHeapHashMap<String, RefPtrWillBeMember<InspectorDatabaseResource> >
DatabaseResourcesHeapMap;
On 2014/03/20 04:42:58, haraken wrote:
> 
> This should be WillBePersistentHeapHashMap.

Done.

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
File Source/modules/webdatabase/InspectorDatabaseResource.h (right):

https://codereview.chromium.org/205853002/diff/1/Source/modules/webdatabase/I...
Source/modules/webdatabase/InspectorDatabaseResource.h:45: class
InspectorDatabaseResource : public
RefCountedWillBeGarbageCollected<InspectorDatabaseResource> {
On 2014/03/20 04:42:58, haraken wrote:
> 
> This should be RefCountedWillBeGarbageCollectedFinalized because Strings need
> destructors.

Done.

[tkent, 2014-03-20 05:12:25]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-20 05:12:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/205853002/20001

[commit-bot: I haz the power, 2014-03-20 05:16:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 05:16:11]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[tkent, 2014-03-20 05:23:11]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-03-20 05:23:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/205853002/20001

[commit-bot: I haz the power, 2014-03-20 06:19:06]

Change committed as 169623

[Mads Ager (chromium), 2014-03-20 06:52:00]

lgtm2