Make BackgroundBudgetService calls asynchronous.

chrome/browser/push_messaging/push_messaging_notification_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/push_messaging/push_messaging_notification_manager.h"
 
 #include <stddef.h>
 
 #include <bitset>
 
@@ skipping 168 matching lines @@
       platform_notification_service->ClosePersistentNotification(
           profile_, notification_database_data.notification_id);
       platform_notification_service->OnPersistentNotificationClose(
           profile_, notification_database_data.notification_id,
           notification_database_data.origin, false /* by_user */);
 
       break;
     }
   }
 
-  // Get the budget for the service worker. This will internally record UMA
-  // for budget development work in the future.
+  // Get the budget for the service worker.
   BackgroundBudgetService* service =
       BackgroundBudgetServiceFactory::GetForProfile(profile_);
-  double budget = service->GetBudget(origin);
+  service->GetBudget(
+      origin,
+      base::Bind(&PushMessagingNotificationManager::DidGetBudget,
+                 weak_factory_.GetWeakPtr(), origin,
+                 service_worker_registration_id, message_handled_closure,
+                 notification_needed, notification_shown));
+}
 
+void PushMessagingNotificationManager::DidGetBudget(
+    const GURL& origin,
+    int64_t service_worker_registration_id,
+    const base::Closure& message_handled_closure,
+    bool notification_needed,
+    bool notification_shown,
+    const double budget) {
   // Record the budget available any time the budget is queried.
   UMA_HISTOGRAM_COUNTS_100("PushMessaging.BackgroundBudget", budget);
 
   // Get the site engagement score. Only used for UMA recording.
   SiteEngagementService* ses_service = SiteEngagementService::Get(profile_);
   double ses_score = ses_service->GetScore(origin);
 
   // Generate histograms for the GetBudget calls which would return "no budget"
   // or "low budget" if an API was available to app developers.
   double cost = BackgroundBudgetService::GetCost(
@@ skipping 63 matching lines @@
     int64_t service_worker_registration_id,
     const base::Closure& message_handled_closure,
     const double budget) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   // If the service needed to show a notification but did not, update the
   // budget.
   double cost = BackgroundBudgetService::GetCost(
       BackgroundBudgetService::CostType::SILENT_PUSH);
   if (budget >= cost) {
-    // Update the stored budget.
+    RecordUserVisibleStatus(
+        content::PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_USED_GRACE);
+
     BackgroundBudgetService* service =
         BackgroundBudgetServiceFactory::GetForProfile(profile_);
-    service->StoreBudget(origin, budget - cost);
+    // Update the stored budget.
+    service->StoreBudget(origin, budget - cost, message_handled_closure);
 
-    RecordUserVisibleStatus(
-        content::PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_USED_GRACE);
-    message_handled_closure.Run();
     return;
   }
 
   RecordUserVisibleStatus(
       content::PUSH_USER_VISIBLE_STATUS_REQUIRED_BUT_NOT_SHOWN_GRACE_EXCEEDED);
   rappor::SampleDomainAndRegistryFromGURL(
       g_browser_process->rappor_service(),
       "PushMessaging.GenericNotificationShown.Origin", origin);
 
   // The site failed to show a notification when one was needed, and they don't
@@ skipping 42 matching lines @@
     message_handled_closure.Run();
     return;
   }
 
   PlatformNotificationServiceImpl::GetInstance()->DisplayPersistentNotification(
       profile_, persistent_notification_id, origin, notification_data,
       NotificationResources());
 
   message_handled_closure.Run();
 }