Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2058513006: Send API error response when chrome.socket.* API receives an invalid port number. (Closed)

Created:
4 years, 6 months ago by lazyboy
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send API error response when chrome.socket.* API receives an invalid port number. We used to call EXTENSION_FUNCTION_VALIDATE to validate these, which would result in CHECK on debug builds and bad_message_ = true in release builds. bad_message_ will end up killing the extension process. BUG=619158 Test=See bug description for repro case. Committed: https://crrev.com/c5ebb340bf9ab615ae58cfcf573c25b946ed5460 Cr-Commit-Position: refs/heads/master@{#399321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M chrome/browser/extensions/api/socket/socket_api_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 6 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lazyboy
4 years, 6 months ago (2016-06-10 21:03:20 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-10 21:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058513006/1
4 years, 6 months ago (2016-06-10 23:40:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 23:45:36 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 23:46:03 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 23:47:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5ebb340bf9ab615ae58cfcf573c25b946ed5460
Cr-Commit-Position: refs/heads/master@{#399321}

Powered by Google App Engine
This is Rietveld 408576698