Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2058513003: DevTools: max length limit for formatting commands (Closed)

Created:
4 years, 6 months ago by luoe
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: max length limit for formatting commands This CL makes sure that any console output is < 10000 characters before we try to apply syntax highlighting to it. Otherwise, it becomes really slow. BUG=611112 Committed: https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8 Cr-Commit-Position: refs/heads/master@{#400836}

Patch Set 1 #

Patch Set 2 : Made const #

Total comments: 4

Patch Set 3 : Address comments #

Patch Set 4 : Remove style changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 2 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
luoe
This CL makes sure that any console output is < 10000 characters before we try ...
4 years, 6 months ago (2016-06-13 20:21:44 UTC) #2
dgozman
> This CL makes sure that any console output is < 10000 characters before we ...
4 years, 6 months ago (2016-06-14 08:55:05 UTC) #3
luoe
https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js#newcode1199 third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1199: this._updateSearch.bind(this); On 2016/06/14 08:55:04, dgozman_slow wrote: > this._updateSearch(); Done. ...
4 years, 6 months ago (2016-06-14 18:29:54 UTC) #5
dgozman
> https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Source/devtools/front_end/console/consoleView.css > File third_party/WebKit/Source/devtools/front_end/console/consoleView.css > (right): > > https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Source/devtools/front_end/console/consoleView.css#newcode59 > third_party/WebKit/Source/devtools/front_end/console/consoleView.css:59: > position: absolute; ...
4 years, 6 months ago (2016-06-15 10:11:43 UTC) #6
luoe
Sounds good. I've removed the style changes and filed a bug, since its a separate ...
4 years, 6 months ago (2016-06-20 20:44:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058513003/60001
4 years, 6 months ago (2016-06-20 20:44:58 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 22:05:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058513003/60001
4 years, 6 months ago (2016-06-20 23:38:09 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-20 23:43:13 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 23:46:36 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8
Cr-Commit-Position: refs/heads/master@{#400836}

Powered by Google App Engine
This is Rietveld 408576698