DevTools: max length limit for formatting commands

DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG=611112
Committed: https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8
Cr-Commit-Position: refs/heads/master@{#400836}

[luoe, 2016-06-13 20:21:43]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org

[luoe, 2016-06-13 20:21:44]

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it.  Otherwise, it becomes really slow.

It also makes the text prompt 'position: absolute' so that typing when a
scrollbar is present doesn't cause the entire console view to need a repaint.

[dgozman, 2016-06-14 08:55:05]

> This CL makes sure that any console output is < 10000 characters before we try
> to apply syntax highlighting to it.  Otherwise, it becomes really slow.
It makes sense to put this into patch description.

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1199:
this._updateSearch.bind(this);
this._updateSearch();

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:59:
position: absolute;
I've tried this in canary, and it doesn't have any difference (I use pain
flashing from rendering to check what's repainted). Am I doing something wrong?

[luoe, 2016-06-14 12:13:00]

Description was changed from

==========
DevTools: max length limit for formatting commands

BUG=611112
==========

to

==========
DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG=611112
==========

[luoe, 2016-06-14 18:29:54]

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
(right):

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js:1199:
this._updateSearch.bind(this);
On 2016/06/14 08:55:04, dgozman_slow wrote:
> this._updateSearch();

Done.

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:59:
position: absolute;
On 2016/06/14 08:55:04, dgozman_slow wrote:
> I've tried this in canary, and it doesn't have any difference (I use pain
> flashing from rendering to check what's repainted). Am I doing something
wrong?

After checking Canary on Mac, it looks like there is no difference there.  I do
see all the console messages repaint on my master branch #398929 on Linux.  I
will do a manual bisect and see if I can pinpoint something down.

[dgozman, 2016-06-15 10:11:43]

>
https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
> (right):
> 
>
https://codereview.chromium.org/2058513003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/console/consoleView.css:59:
> position: absolute;
> On 2016/06/14 08:55:04, dgozman_slow wrote:
> > I've tried this in canary, and it doesn't have any difference (I use pain
> > flashing from rendering to check what's repainted). Am I doing something
> wrong?
> 
> After checking Canary on Mac, it looks like there is no difference there.  I
do
> see all the console messages repaint on my master branch #398929 on Linux.  I
> will do a manual bisect and see if I can pinpoint something down.

Let's land without this change, and make a separate patch if you confirm the
issue.
lgtm

[luoe, 2016-06-20 20:44:22]

Sounds good.  I've removed the style changes and filed a bug, since its a
separate issue: https://bugs.chromium.org/p/chromium/issues/detail?id=621644

[luoe, 2016-06-20 20:44:29]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 20:44:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058513003/60001

[commit-bot: I haz the power, 2016-06-20 22:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 22:05:29]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-06-20 23:37:32]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-06-20 23:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2058513003/#ps60001
(title: "Remove style changes")

[commit-bot: I haz the power, 2016-06-20 23:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058513003/60001

[commit-bot: I haz the power, 2016-06-20 23:43:12]

Description was changed from

==========
DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG=611112
==========

to

==========
DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG=611112
==========

[commit-bot: I haz the power, 2016-06-20 23:43:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-20 23:46:35]

Description was changed from

==========
DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG=611112
==========

to

==========
DevTools: max length limit for formatting commands

This CL makes sure that any console output is < 10000 characters before we try
to apply syntax highlighting to it. Otherwise, it becomes really slow.

BUG=611112

Committed: https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8
Cr-Commit-Position: refs/heads/master@{#400836}
==========

[commit-bot: I haz the power, 2016-06-20 23:46:36]

Patchset 4 (id:??) landed as
https://crrev.com/9f222f707cf66be00de0cec49cd86323884206b8
Cr-Commit-Position: refs/heads/master@{#400836}