Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2058513002: Add billing address identifier to WalletMaskedCard. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org, albertb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add billing address identifier to WalletMaskedCard. BUG=602663 Committed: https://crrev.com/f92801e56ecb266525bc52a6a398db8affbc6247 Cr-Commit-Position: refs/heads/master@{#399278}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update converter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sync/protocol/autofill_specifics.proto View 1 chunk +3 lines, -1 line 0 comments Download
M sync/protocol/proto_value_conversions.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
please use gerrit instead
zea@: ptal.
4 years, 6 months ago (2016-06-09 22:52:02 UTC) #2
Nicolas Zea
https://codereview.chromium.org/2058513002/diff/1/sync/protocol/autofill_specifics.proto File sync/protocol/autofill_specifics.proto (right): https://codereview.chromium.org/2058513002/diff/1/sync/protocol/autofill_specifics.proto#newcode116 sync/protocol/autofill_specifics.proto:116: optional string billing_address_id = 8; update proto_value_conversions.cc as well?
4 years, 6 months ago (2016-06-09 22:59:02 UTC) #3
please use gerrit instead
ptal patch 2 https://codereview.chromium.org/2058513002/diff/1/sync/protocol/autofill_specifics.proto File sync/protocol/autofill_specifics.proto (right): https://codereview.chromium.org/2058513002/diff/1/sync/protocol/autofill_specifics.proto#newcode116 sync/protocol/autofill_specifics.proto:116: optional string billing_address_id = 8; On ...
4 years, 6 months ago (2016-06-10 01:22:21 UTC) #4
Nicolas Zea
lgtm
4 years, 6 months ago (2016-06-10 19:48:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058513002/20001
4 years, 6 months ago (2016-06-10 20:11:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 21:45:54 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 21:46:01 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 21:48:31 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f92801e56ecb266525bc52a6a398db8affbc6247
Cr-Commit-Position: refs/heads/master@{#399278}

Powered by Google App Engine
This is Rietveld 408576698