third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js - Issue 2058323002: Add ARIA panel to accessibility sidebar pane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Issue 2058323002: Add ARIA panel to accessibility sidebar pane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Preliminary cleanup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js ('K') | « third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js ('k') | third_party/WebKit/Source/devtools/front_end/accessibility/accessibilityNode.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

index d2736e5ddb5f2bc72a67cde602896d5b4aa13ce6..ac6bba54b0d9b4a4fea6f82b4548aa630542f993 100644

--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

@@ -59,9 +59,15 @@ WebInspector.AccessibilitySidebarView.prototype = {

this._axNodeSubPane.show(this.element);

this._axNodeSubPane.expand();

+ this._ariaSubPane = new WebInspector.AXARIAAttributesSubPane();

+ this._ariaSubPane.setNode(this.node());

+ this._ariaSubPane.show(this.element);

+ this._ariaSubPane.expand();

this._sidebarPaneStack = new WebInspector.SidebarPaneStack();

this._sidebarPaneStack.element.classList.add("flex-auto");

this._sidebarPaneStack.show(this.element);

+ this._sidebarPaneStack.addPane(this._ariaSubPane);

this._sidebarPaneStack.addPane(this._axNodeSubPane);

}

@@ -87,6 +93,8 @@ WebInspector.AccessibilitySidebarView.prototype = {

this._node = WebInspector.context.flavor(WebInspector.DOMNode);

if (this._axNodeSubPane)

this._axNodeSubPane.setNode(this._node);

+ if (this._ariaSubPane)

+ this._ariaSubPane.setNode(this._node);

this.update();