Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2058323002: Add ARIA panel to accessibility sidebar pane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
index ed0d4be3ccadb24ccadcc97d125d56624a9da96c..e617227c9a5a95280762c669639fd799b265a90c 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
@@ -201,15 +201,18 @@ WebInspector.ElementsPanel.prototype = {
{
var extensions = self.runtime.extensions("@WebInspector.View");
+ var promises = [];
for (var i = 0; i < extensions.length; ++i) {
var descriptor = extensions[i].descriptor();
if (descriptor["location"] !== "elements-panel")
continue;
var title = WebInspector.UIString(descriptor["title"]);
- extensions[i].instancePromise().then(addSidebarView.bind(this, title));
+ promises.push(extensions[i].instancePromise().then(addSidebarView.bind(this, title)));
}
+ Promise.all(promises).then(this._sidebarViewsLoadedForTest.bind(this));
+
/**
* @param {string} title
* @param {!Object} object
@@ -225,6 +228,11 @@ WebInspector.ElementsPanel.prototype = {
}
},
+ _sidebarViewsLoadedForTest: function()
+ {
+ // For sniffing in tests.
+ },
+
/**
* @override
* @param {!WebInspector.Target} target

Powered by Google App Engine
This is Rietveld 408576698