Add ARIA panel to accessibility sidebar pane

third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

Index: third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
index b525281bd5b032f4a800385af50e97e07704487a..710d79c30f4ec5aba1665c18b794fe798b7f7589 100644
--- a/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
+++ b/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js
@@ -10,6 +10,7 @@ WebInspector.AccessibilitySidebarView = function()
 {
     WebInspector.ThrottledView.call(this, WebInspector.UIString("Accessibility"));
     this._axNodeSubPane = null;
+    this._ariaSubPane = null;
     this._node = null;
     this._sidebarPaneStack = null;
     WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, this._pullNode, this);
@@ -40,12 +41,18 @@ WebInspector.AccessibilitySidebarView.prototype = {
         {
             if (this._axNodeSubPane)
                 this._axNodeSubPane.setAXNode(accessibilityNode);
+            this._accessibilityNodeUpdatedForTest();
         }
         var node = this.node();
         return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNode(node.id)
             .then(accessibilityNodeCallback.bind(this))
     },
 
+    _accessibilityNodeUpdatedForTest: function()
+    {
+         // For sniffing in tests.
+    },
+
     /**
      * @override
      */
@@ -57,10 +64,17 @@ WebInspector.AccessibilitySidebarView.prototype = {
             this._axNodeSubPane = new WebInspector.AXNodeSubPane();
             this._axNodeSubPane.setNode(this.node());
             this._axNodeSubPane.show(this.element);
+            this._axNodeSubPane.requestReveal();
+
+            this._ariaSubPane = new WebInspector.ARIAAttributesPane();
+            this._ariaSubPane.setNode(this.node());
+            this._ariaSubPane.show(this.element);

[dgozman, 2016/07/25 17:39:38]

We don't have to show pane here, as we add it to the stack below.

[aboxhall, 2016/07/25 19:49:20]

Done.

+            this._ariaSubPane.requestReveal();

[dgozman, 2016/07/25 17:39:38]

requestReveal should be called after adding the to the pane stack.

[aboxhall, 2016/07/25 19:49:20]

Done.

 
             this._sidebarPaneStack = new WebInspector.SidebarPaneStack();
             this._sidebarPaneStack.element.classList.add("flex-auto");
             this._sidebarPaneStack.show(this.element);
+            this._sidebarPaneStack.addPane(this._ariaSubPane);
             this._sidebarPaneStack.addPane(this._axNodeSubPane);
         }
 
@@ -86,6 +100,8 @@ WebInspector.AccessibilitySidebarView.prototype = {
         this._node = WebInspector.context.flavor(WebInspector.DOMNode);
         if (this._axNodeSubPane)
             this._axNodeSubPane.setNode(this._node);
+        if (this._ariaSubPane)
+            this._ariaSubPane.setNode(this._node);
         this.update();
     },