Add ARIA panel to accessibility sidebar pane

third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.ThrottledView}
  */
 WebInspector.AccessibilitySidebarView = function()
 {
     WebInspector.ThrottledView.call(this, WebInspector.UIString("Accessibility"));
     this._axNodeSubPane = null;
+    this._ariaSubPane = null;
     this._node = null;
     this._sidebarPaneStack = null;
     WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode, this._pullNode, this);
     this._pullNode();
 }
 
 WebInspector.AccessibilitySidebarView.prototype = {
     /**
      * @return {?WebInspector.DOMNode}
      */
@@ skipping 10 matching lines @@
     doUpdate: function()
     {
         /**
          * @param {?AccessibilityAgent.AXNode} accessibilityNode
          * @this {WebInspector.AccessibilitySidebarView}
          */
         function accessibilityNodeCallback(accessibilityNode)
         {
             if (this._axNodeSubPane)
                 this._axNodeSubPane.setAXNode(accessibilityNode);
+            this._accessibilityNodeUpdatedForTest();
         }
         var node = this.node();
         return WebInspector.AccessibilityModel.fromTarget(node.target()).getAXNode(node.id)
             .then(accessibilityNodeCallback.bind(this))
     },
 
+    _accessibilityNodeUpdatedForTest: function()
+    {
+         // For sniffing in tests.
+    },
+
     /**
      * @override
      */
     wasShown: function()
     {
         WebInspector.ThrottledView.prototype.wasShown.call(this);
 
         if (!this._sidebarPaneStack) {
             this._axNodeSubPane = new WebInspector.AXNodeSubPane();
             this._axNodeSubPane.setNode(this.node());
             this._axNodeSubPane.show(this.element);
+            this._axNodeSubPane.requestReveal();
+
+            this._ariaSubPane = new WebInspector.ARIAAttributesPane();
+            this._ariaSubPane.setNode(this.node());
+            this._ariaSubPane.show(this.element);

[dgozman, 2016/07/25 17:39:38]

We don't have to show pane here, as we add it to the stack below.

[aboxhall, 2016/07/25 19:49:20]

Done.

+            this._ariaSubPane.requestReveal();

[dgozman, 2016/07/25 17:39:38]

requestReveal should be called after adding the to the pane stack.

[aboxhall, 2016/07/25 19:49:20]

Done.

 
             this._sidebarPaneStack = new WebInspector.SidebarPaneStack();
             this._sidebarPaneStack.element.classList.add("flex-auto");
             this._sidebarPaneStack.show(this.element);
+            this._sidebarPaneStack.addPane(this._ariaSubPane);
             this._sidebarPaneStack.addPane(this._axNodeSubPane);
         }
 
         WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.AttrModified, this._onAttrChange, this);
         WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.AttrRemoved, this._onAttrChange, this);
         WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.CharacterDataModified, this._onNodeChange, this);
         WebInspector.targetManager.addModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.ChildNodeCountUpdated, this._onNodeChange, this);
     },
 
     /**
      * @override
      */
     willHide: function()
     {
         WebInspector.targetManager.removeModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.AttrModified, this._onAttrChange, this);
         WebInspector.targetManager.removeModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.AttrRemoved, this._onAttrChange, this);
         WebInspector.targetManager.removeModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.CharacterDataModified, this._onNodeChange, this);
         WebInspector.targetManager.removeModelListener(WebInspector.DOMModel, WebInspector.DOMModel.Events.ChildNodeCountUpdated, this._onNodeChange, this);
     },
 
     _pullNode: function()
     {
         this._node = WebInspector.context.flavor(WebInspector.DOMNode);
         if (this._axNodeSubPane)
             this._axNodeSubPane.setNode(this._node);
+        if (this._ariaSubPane)
+            this._ariaSubPane.setNode(this._node);
         this.update();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onAttrChange: function(event)
     {
         if (!this.node())
             return;
@@ skipping 80 matching lines @@
         treeOutline.registerRequiredCSS("accessibility/accessibilityNode.css");
         treeOutline.registerRequiredCSS("components/objectValue.css");
 
         treeOutline.element.classList.add("hidden");
         this.element.appendChild(treeOutline.element);
         return treeOutline;
     },
 
     __proto__: WebInspector.View.prototype
 }