Add ARIA panel to accessibility sidebar pane

third_party/WebKit/LayoutTests/inspector/elements/accessibility/accessibility-pane-test.js

+var initialize_AccessibilityTest = function() {
+
+/**
+ * @return {Promise}
+ */
+InspectorTest.showAccessibilityView = function()
+{
+    var sidebarPane = _getAccessibilitySidebarPane();
+    if (sidebarPane) {
+        sidebarPane.requestReveal();
+        return Promise.resolve(sidebarPane);
+    } else {
+        return _waitForViewsLoaded()
+            .then(() => {

[dgozman, 2016/07/25 17:39:38]

I think we can just pass result of Promise.all() into .then(...). No need for
extra wrapper function.

[aboxhall, 2016/07/25 19:49:19]

Hm, I think I need to extra wrapper so that Promise.all() is executed after
waitForViewsLoaded() resolves, not when .then() is interpreted.

(I did try passing Promise.all() directly and the test times out, so that's my
assumption as to what's going on.)

[dgozman, 2016/07/25 22:41:53]

You are right! I missed that.

+                      return Promise.all([InspectorTest.waitForAccessibilityNodeUpdate(),
+                                          InspectorTest.showAccessibilityView()]);
+                  });
+    }
+}
+
+
+/**
+ * @return {Promise}
+ */
+_waitForViewsLoaded = function() {

[dgozman, 2016/07/25 17:39:38]

InspectorTest._waitForViewsLoaded

[aboxhall, 2016/07/25 19:49:19]

I figured it doesn't need to be accessible outside this scope?

[dgozman, 2016/07/25 22:41:53]

It doesn't, but that's how we usually name them. At least, change it according
to style guide (name after function, { on next line):

function _waitForViewsLoaded()
{
...
}

+    return new Promise(function(resolve, reject)
+    {
+        InspectorTest.addSniffer(WebInspector.ElementsPanel.prototype,
+                                 "_sidebarViewsLoadedForTest",
+                                 () => { resolve(); });

[dgozman, 2016/07/25 17:39:38]

Can just pass |resolve| as a sniffer.

[aboxhall, 2016/07/25 19:49:19]

Done.

+        WebInspector.panels.elements._loadSidebarViews();
+    });
+}
+
+_getAccessibilitySidebarPane = function()

[dgozman, 2016/07/25 17:39:38]

InspectorTest._getAccessibilitySidebarPane

[aboxhall, 2016/07/25 19:49:19]

Similar to above.

+{
+    var sidebarViews = WebInspector.panels.elements._elementsSidebarViews;
+    var sidebarPane = sidebarViews.find((view) => { return view._title === "Accessibility"; });
+    return sidebarPane;
+}
+
+/**
+ * @param {string} idValue
+ * @return {Promise}
+ */
+InspectorTest.selectNodeAndWaitForAccessibility = function(idValue)
+{
+    return Promise.all([InspectorTest.waitForAccessibilityNodeUpdateInARIAPane(),
+                        InspectorTest.waitForAccessibilityNodeUpdate(),
+                        new Promise(function(resolve) {
+                            InspectorTest.selectNodeWithId(idValue, resolve);
+                        })]);
+}
+
+InspectorTest.dumpSelectedElementAccessibilityNode = function()
+{
+    var sidebarPane = _getAccessibilitySidebarPane();
+
+    if (!sidebarPane) {
+        InspectorTest.addResult('No sidebarPane in dumpSelectedElementAccessibilityNode');
+        InspectorTest.completeTest();
+        return;
+    }
+    InspectorTest.dumpAccessibilityNode(sidebarPane._axNodeSubPane._axNode);
+}
+
+/**
+ * @param {!AccessibilityAgent.AXNode} accessibilityNode
+ */
+InspectorTest.dumpAccessibilityNode = function(accessibilityNode)
+{
+    if (!accessibilityNode) {
+        InspectorTest.addResult("<null>");
+        InspectorTest.completeTest();
+        return;
+    }
+
+    var builder = [];
+    builder.push(accessibilityNode.role.value);
+    builder.push(accessibilityNode.name ? '"' + accessibilityNode.name.value + '"'
+                : "<undefined>");
+    if ('properties' in accessibilityNode) {

[dgozman, 2016/07/25 17:39:38]

style: double quotes

[aboxhall, 2016/07/25 19:49:19]

Oh, weird presubmit didn't catch that. Fixed.

+        for (var property of accessibilityNode.properties) {
+            if ('value' in property)

[dgozman, 2016/07/25 17:39:38]

ditto

[aboxhall, 2016/07/25 19:49:19]

Done.

+                builder.push(property.name + '="' + property.value.value + '"');
+        }
+    }
+    InspectorTest.addResult(builder.join(" "));
+}
+
+/**
+ * @param {string} attribute
+ * @return {?WebInspector.ARIAAttributesTreeElement}
+ */
+InspectorTest.findARIAAttributeTreeElement = function(attribute)
+{
+    var sidebarPane = _getAccessibilitySidebarPane();
+
+    if (!sidebarPane) {
+        InspectorTest.completeTest();

[dgozman, 2016/07/25 17:39:38]

Add error message similar to above.

[aboxhall, 2016/07/25 19:49:19]

Done.

+        return;
+    }
+
+    var ariaSubPane = sidebarPane._ariaSubPane;
+    var treeOutline = ariaSubPane._treeOutline;
+    var childNodes = treeOutline._rootElement._children;
+    for (var treeElement of childNodes) {
+        if (treeElement._attribute.name === attribute)
+            return treeElement;
+    }
+    return null;
+}
+
+/**
+ * @return {Promise}
+ */
+InspectorTest.waitForAccessibilityNodeUpdate = function()
+{
+    return new Promise(function(resolve, reject)
+    {
+        InspectorTest.addSniffer(WebInspector.AccessibilitySidebarView.prototype, "_accessibilityNodeUpdatedForTest", resolve);
+    });
+}
+
+/**
+ * @return {Promise}
+ */
+InspectorTest.waitForAccessibilityNodeUpdateInARIAPane = function()
+{
+    return new Promise(function(resolve, reject)
+    {
+        InspectorTest.addSniffer(WebInspector.ARIAAttributesPane.prototype, "_gotNodeForTest", resolve);
+    });
+}
+};