blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Changed BlimpContentsObserver's navigation methods to OnNavigationStateChanged Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/blimp_navigation_controller_impl.cc ('K') | « blimp/client/feature/navigation_feature.h ('k') | blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpNavigationController.java » ('j') | blimp/client/public/blimp_navigation_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java

diff --git a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java

index 7d7a85813291ae916a8bd3d65fa12644b41ae819..23335e39ecbb674ca464c9a5e40ff7ce9ac09036 100644

--- a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java

+++ b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java

@@ -15,5 +15,5 @@ public interface BlimpContentsObserver {

* Invoked when the URL of the BlimpContents is changes.

* @param url the new URL.

- void onUrlUpdated(String url);

+ void onNavigationStateChanged();

}