blimp/client/core/blimp_contents_impl.cc - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/blimp_contents_impl.cc

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Changed BlimpContentsObserver's navigation methods to OnNavigationStateChanged Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/blimp_contents_impl.h ('k') | blimp/client/core/blimp_contents_impl_unittest.cc » ('j') | blimp/client/core/blimp_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/blimp_contents_impl.cc

diff --git a/blimp/client/core/blimp_contents_impl.cc b/blimp/client/core/blimp_contents_impl.cc

index 3e93e9240e82b6f48fafdffb511afe154fe3921a..300a8d4e3b5d52ee1e02d542e225ec992ec6804d 100644

--- a/blimp/client/core/blimp_contents_impl.cc

+++ b/blimp/client/core/blimp_contents_impl.cc

@@ -22,7 +22,8 @@ const char kBlimpContentsImplAndroidKey[] = "blimp_contents_impl_android";

#endif // OS_ANDROID

}

-BlimpContentsImpl::BlimpContentsImpl() : navigation_controller_(this) {}

+BlimpContentsImpl::BlimpContentsImpl()

+ : navigation_controller_(this, nullptr) {}

BlimpContentsImpl::~BlimpContentsImpl() {}

@@ -58,8 +59,9 @@ void BlimpContentsImpl::RemoveObserver(BlimpContentsObserver* observer) {

observers_.RemoveObserver(observer);

}

-void BlimpContentsImpl::NotifyURLLoaded(const GURL& url) {

- FOR_EACH_OBSERVER(BlimpContentsObserver, observers_, OnURLUpdated(url));

+void BlimpContentsImpl::OnNavigationStateChanged() {

+ FOR_EACH_OBSERVER(BlimpContentsObserver, observers_,

+ OnNavigationStateChanged());

}

} // namespace client