blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Changed BlimpContentsObserver's navigation methods to OnNavigationStateChanged Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/android/blimp_navigation_controller_impl_android.cc ('k') | blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpNavigationControllerImpl.java » ('j') | blimp/client/core/blimp_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java

diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java

index b000c080103d7b75ed70c8f309ff1283bee38cdf..e9b6d0a836e241f748375de0b2c4fc999880f0bc 100644

--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java

+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpContentsObserverProxy.java

@@ -42,9 +42,9 @@ class BlimpContentsObserverProxy implements BlimpContentsObserver {

@Override

@CalledByNative

- public void onUrlUpdated(String url) {

+ public void onNavigationStateChanged() {

for (BlimpContentsObserver observer : mObservers) {

- observer.onUrlUpdated(url);

+ observer.onNavigationStateChanged();

}