blimp/client/BUILD.gn - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Addressed code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 663f7f69c46a9aad75acdf4fa73215750cdcb5d8..cb0423b961fffeedc41e318d0a22df3fce8e6c0d 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -170,6 +170,8 @@ source_set("test_support") {

sources = [

"feature/mock_ime_feature_delegate.cc",

"feature/mock_ime_feature_delegate.h",

+ "feature/mock_navigation_feature.cc",

nyquist 2016/07/25 22:59:06 Could we move these two new files to //blimp/clien

+ "feature/mock_navigation_feature.h",

"feature/mock_navigation_feature_delegate.cc",

"feature/mock_navigation_feature_delegate.h",

"feature/mock_render_widget_feature_delegate.cc",

@@ -181,9 +183,12 @@ source_set("test_support") {

deps = [

":session",

"//skia",

- "//testing/gmock",

"//url",

]

+ public_deps = [

+ "//testing/gmock",

+ ]

}

source_set("compositor") {

« no previous file with comments | « no previous file | blimp/client/core/BUILD.gn » ('j') | blimp/client/core/BUILD.gn » ('J')