Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: blimp/client/core/contents/navigation_feature.h

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core
Patch Set: Removed BlimpContentsTest.java Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/navigation_feature.h
diff --git a/blimp/client/feature/navigation_feature.h b/blimp/client/core/contents/navigation_feature.h
similarity index 79%
rename from blimp/client/feature/navigation_feature.h
rename to blimp/client/core/contents/navigation_feature.h
index c5dd226601592bb05823749ce1e61d3d99ab2917..7b128dd4103a169ba014a721a7dd514a85d56481 100644
--- a/blimp/client/feature/navigation_feature.h
+++ b/blimp/client/core/contents/navigation_feature.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef BLIMP_CLIENT_FEATURE_NAVIGATION_FEATURE_H_
-#define BLIMP_CLIENT_FEATURE_NAVIGATION_FEATURE_H_
+#ifndef BLIMP_CLIENT_CORE_CONTENTS_NAVIGATION_FEATURE_H_
+#define BLIMP_CLIENT_CORE_CONTENTS_NAVIGATION_FEATURE_H_
#include <map>
#include <string>
@@ -48,21 +48,23 @@ class NavigationFeature : public BlimpMessageProcessor {
void SetDelegate(int tab_id, NavigationFeatureDelegate* delegate);
void RemoveDelegate(int tab_id);
- void NavigateToUrlText(int tab_id, const std::string& url_text);
- void Reload(int tab_id);
- void GoForward(int tab_id);
- void GoBack(int tab_id);
+ // Virtual for testing.
+ virtual void NavigateToUrlText(int tab_id, const std::string& url_text);
+ virtual void Reload(int tab_id);
+ virtual void GoForward(int tab_id);
+ virtual void GoBack(int tab_id);
// BlimpMessageProcessor implementation.
void ProcessMessage(std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) override;
- private:
+ protected:
+ // Finds the NavigationFeatureDelegate for a |tab_id|, protected for unit
+ // tests.
NavigationFeatureDelegate* FindDelegate(const int tab_id);
- typedef base::SmallMap<std::map<int, NavigationFeatureDelegate*>> DelegateMap;
-
- DelegateMap delegates_;
+ private:
+ base::SmallMap<std::map<int, NavigationFeatureDelegate*>> delegates_;
// Used to send BlimpMessage::NAVIGATION messages to the engine.
std::unique_ptr<BlimpMessageProcessor> outgoing_message_processor_;
@@ -73,4 +75,4 @@ class NavigationFeature : public BlimpMessageProcessor {
} // namespace client
} // namespace blimp
-#endif // BLIMP_CLIENT_FEATURE_NAVIGATION_FEATURE_H_
+#endif // BLIMP_CLIENT_CORE_CONTENTS_NAVIGATION_FEATURE_H_
« no previous file with comments | « blimp/client/core/contents/mock_navigation_feature_delegate.cc ('k') | blimp/client/core/contents/navigation_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698