blimp/client/public/contents/blimp_navigation_controller.h - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/contents/blimp_navigation_controller.h

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Kevin's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/contents/navigation_feature.h ('K') | « blimp/client/public/contents/blimp_contents_observer.h ('k') | blimp/client/session/blimp_client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/public/contents/blimp_navigation_controller.h

diff --git a/blimp/client/public/contents/blimp_navigation_controller.h b/blimp/client/public/contents/blimp_navigation_controller.h

index c8509e9cbd39fcdb81eae7027b0a1ed85b1f296c..f2d38ee15ad2ac50c63aa88c3e84725ab0432fa7 100644

--- a/blimp/client/public/contents/blimp_navigation_controller.h

+++ b/blimp/client/public/contents/blimp_navigation_controller.h

@@ -26,6 +26,15 @@ class BlimpNavigationController {

// provided |url|.

virtual void LoadURL(const GURL& url) = 0;

Kevin M 2016/07/29 21:05:33 Should we add parameters for tabs here too?

shaktisahu 2016/07/29 22:57:31 No, the plan is that navigation controller will no

+ // Reloads the current entry.

+ virtual void Reload() = 0;

+ // Navigation relative to the "current entry".

+ virtual bool CanGoBack() const = 0;

+ virtual bool CanGoForward() const = 0;

+ virtual void GoBack() = 0;

+ virtual void GoForward() = 0;

// Retrieves the URL of the currently selected item in the navigation list.

virtual const GURL& GetURL() = 0;