blimp/client/core/contents/blimp_navigation_controller_delegate.h - Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_delegate.h

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core

Patch Set: Kevin's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/contents/blimp_contents_impl_unittest.cc ('K') | « blimp/client/core/contents/blimp_contents_impl_unittest.cc ('k') | blimp/client/core/contents/blimp_navigation_controller_impl.h » ('j') | blimp/client/core/contents/blimp_navigation_controller_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_navigation_controller_delegate.h

diff --git a/blimp/client/core/contents/blimp_navigation_controller_delegate.h b/blimp/client/core/contents/blimp_navigation_controller_delegate.h

index c9bb7084505443f7b7531ecf61c43976f5330e9e..a34d96e4db4a8c9d42008c0109605a57a296d55f 100644

--- a/blimp/client/core/contents/blimp_navigation_controller_delegate.h

+++ b/blimp/client/core/contents/blimp_navigation_controller_delegate.h

@@ -17,8 +17,8 @@ class BlimpNavigationControllerDelegate {

public:

virtual ~BlimpNavigationControllerDelegate() = default;

- // Invoked whenever a new URL has been loaded.

- virtual void NotifyURLLoaded(const GURL& url) = 0;

+ // Informs the delegate that navigation state has been changed.

Kevin M 2016/07/29 21:05:32 was/has changed no need to use the passive voice

shaktisahu 2016/07/29 22:57:30 Done.

+ virtual void OnNavigationStateChanged() = 0;

protected:

BlimpNavigationControllerDelegate() {}