Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: blimp/client/core/BUILD.gn

Issue 2058263002: Tied up BlimpNavigationController to NavigationFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_core
Patch Set: Addressed code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 declare_args() { 10 declare_args() {
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 sources = [ 99 sources = [
100 "blimp_client_context_impl_unittest.cc", 100 "blimp_client_context_impl_unittest.cc",
101 "blimp_contents_impl_unittest.cc", 101 "blimp_contents_impl_unittest.cc",
102 "blimp_navigation_controller_impl_unittest.cc", 102 "blimp_navigation_controller_impl_unittest.cc",
103 ] 103 ]
104 104
105 deps = [ 105 deps = [
106 ":core", 106 ":core",
107 "//base", 107 "//base",
108 "//blimp/client:test_support",
nyquist 2016/07/25 22:59:06 Does this have to live here? Could we have a new t
108 "//blimp/client/public:public_headers", 109 "//blimp/client/public:public_headers",
109 "//blimp/client/test", 110 "//blimp/client/test",
110 "//testing/gtest", 111 "//testing/gtest",
111 "//url", 112 "//url",
112 ] 113 ]
113 } 114 }
114 115
115 if (is_android) { 116 if (is_android) {
116 # This target is here to let //chrome depend on 117 # This target is here to let //chrome depend on
117 # //blimp/client/public:public_java and automatically get the correct 118 # //blimp/client/public:public_java and automatically get the correct
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 generate_jni("dummy_core_jni_headers") { 177 generate_jni("dummy_core_jni_headers") {
177 visibility = [ ":*" ] 178 visibility = [ ":*" ]
178 179
179 sources = [ 180 sources = [
180 "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java", 181 "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java",
181 ] 182 ]
182 183
183 jni_package = "blimp/client/core" 184 jni_package = "blimp/client/core"
184 } 185 }
185 } 186 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698