Tied up BlimpNavigationController to NavigationFeature

blimp/client/core/contents/blimp_contents_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <blimp/client/core/contents/fake_navigation_feature.h>

[Kevin M, 2016/08/01 23:41:58]

Should use "" instead of <>, move into the second include block.

Eclipse refactoring? :\

[shaktisahu, 2016/08/02 17:47:52]

Yes.. Eclipse refactoring.

 #include "blimp/client/core/contents/blimp_contents_impl.h"
 
 #include "base/message_loop/message_loop.h"
 #include "blimp/client/core/contents/blimp_contents_impl.h"
 #include "blimp/client/public/contents/blimp_contents_observer.h"
+#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blimp {
 namespace client {
 namespace {
 
 const GURL kExampleURL = GURL("https://www.example.com/");

[Kevin M, 2016/08/01 23:41:58]

Globals must be POD types e.g. const char[]

[shaktisahu, 2016/08/02 17:47:52]

Done.

 const GURL kOtherExampleURL = GURL("https://www.otherexample.com/");
 
-class TestBlimpContentsObserver : public BlimpContentsObserver {
+class MockBlimpContentsObserver : public BlimpContentsObserver {
  public:
-  TestBlimpContentsObserver() = default;
-  ~TestBlimpContentsObserver() override = default;
+  MockBlimpContentsObserver() = default;
+  ~MockBlimpContentsObserver() override = default;
 
-  void OnURLUpdated(const GURL& url) override { last_url_ = url; }
-
-  GURL GetLastURL() { return last_url_; }
+  MOCK_METHOD0(OnNavigationStateChanged, void());
 
  private:
-  GURL last_url_;
-
-  DISALLOW_COPY_AND_ASSIGN(TestBlimpContentsObserver);
+  DISALLOW_COPY_AND_ASSIGN(MockBlimpContentsObserver);
 };
 
 TEST(BlimpContentsImplTest, Basic) {

[Kevin M, 2016/08/01 23:41:58]

Test name is too basic ;)

RouteNavigationStateChanged?

[shaktisahu, 2016/08/02 17:47:52]

Done.

   base::MessageLoop loop;
   BlimpContentsImpl blimp_contents;
 
-  BlimpNavigationController& navigation_controller =
+  BlimpNavigationControllerImpl& navigation_controller =
       blimp_contents.GetNavigationController();
+  FakeNavigationFeature feature;
+  feature.SetDelegate(1, &navigation_controller);
+  navigation_controller.SetNavigationFeatureForTesting(&feature);
 
-  TestBlimpContentsObserver observer1;
+  testing::StrictMock<MockBlimpContentsObserver> observer1;
   blimp_contents.AddObserver(&observer1);
-  TestBlimpContentsObserver observer2;
+  testing::StrictMock<MockBlimpContentsObserver> observer2;
   blimp_contents.AddObserver(&observer2);
 
+  EXPECT_CALL(observer1, OnNavigationStateChanged());
+  EXPECT_CALL(observer2, OnNavigationStateChanged()).Times(2);
+
   navigation_controller.LoadURL(kExampleURL);
   loop.RunUntilIdle();
 
   EXPECT_EQ(kExampleURL, navigation_controller.GetURL());
-  EXPECT_EQ(kExampleURL, observer1.GetLastURL());
-  EXPECT_EQ(kExampleURL, observer2.GetLastURL());
 
   // Observer should no longer receive callbacks.
   blimp_contents.RemoveObserver(&observer1);
 
   navigation_controller.LoadURL(kOtherExampleURL);
   loop.RunUntilIdle();
 
   EXPECT_EQ(kOtherExampleURL, navigation_controller.GetURL());
-  EXPECT_EQ(kExampleURL, observer1.GetLastURL());
-  EXPECT_EQ(kOtherExampleURL, observer2.GetLastURL());
 }
 
 }  // namespace
 }  // namespace client
 }  // namespace blimp