Tied up BlimpNavigationController to NavigationFeature

blimp/client/core/contents/blimp_navigation_controller_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_CORE_CONTENTS_BLIMP_NAVIGATION_CONTROLLER_IMPL_H_
 #define BLIMP_CLIENT_CORE_CONTENTS_BLIMP_NAVIGATION_CONTROLLER_IMPL_H_
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
+#include "blimp/client/core/contents/navigation_feature.h"
 #include "blimp/client/public/contents/blimp_navigation_controller.h"
 #include "url/gurl.h"
 
+class SkBitmap;
+
 namespace blimp {
 namespace client {
 
 class BlimpContentsObserver;
 class BlimpNavigationControllerDelegate;
 
-// BlimpContentsImpl is the implementation of the core class in
-// //blimp/client/core, the BlimpContents.
-// The BlimpNavigationControllerImpl is the implementation part of
-// BlimpNavigationController. It maintains the back-forward list for a
-// BlimpContentsImpl and manages all navigation within that list.
-class BlimpNavigationControllerImpl : public BlimpNavigationController {
+class BlimpNavigationControllerImpl
+    : public BlimpNavigationController,
+      public NavigationFeature::NavigationFeatureDelegate {
  public:
   explicit BlimpNavigationControllerImpl(
-      BlimpNavigationControllerDelegate* delegate);
+      BlimpNavigationControllerDelegate* delegate,
+      NavigationFeature* feature);
   ~BlimpNavigationControllerImpl() override;
 
   // BlimpNavigationController implementation.
   void LoadURL(const GURL& url) override;
+  void Reload() override;
+  bool CanGoBack() const override;
+  bool CanGoForward() const override;
+  void GoBack() override;
+  void GoForward() override;
+

[Kevin M, 2016/07/29 21:05:32]

Remove newline to keep these overrides together as a single semantic block.

   const GURL& GetURL() override;
 
+  // For testing only.
+  void SetNavigationFeatureForTesting(NavigationFeature* feature);
+
  private:
-  void NotifyDelegateURLLoaded(const GURL& url);
+  // NavigationFeatureDelegate implementation.
+  void OnUrlChanged(int tab_id, const GURL& url) override;
+  void OnFaviconChanged(int tab_id, const SkBitmap& favicon) override;
+  void OnTitleChanged(int tab_id, const std::string& title) override;
+  void OnLoadingChanged(int tab_id, bool loading) override;
+  void OnPageLoadStatusUpdate(int tab_id, bool completed) override;
+
+  // The |navigation_feature_| is responsible for sending and receiving the
+  // navigation state to the server over the proto channel. The life time of
+  // |navigation_feature_| must remain valid throughout |this|.

[Kevin M, 2016/07/29 21:05:32]

Lifetime requirement comments should be documented in the constructor comments.

+  NavigationFeature* navigation_feature_;
 
   // The delegate contains functionality required for the navigation controller
   // to function correctly. It is also invoked on relevant state changes of the
   // navigation controller.
   BlimpNavigationControllerDelegate* delegate_;
 
   // The currently active URL.
   GURL current_url_;
 
-  // TODO(shaktisahu): Remove this after integration with NavigationFeature.
-  base::WeakPtrFactory<BlimpNavigationControllerImpl> weak_ptr_factory_;
-
   DISALLOW_COPY_AND_ASSIGN(BlimpNavigationControllerImpl);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_CORE_CONTENTS_BLIMP_NAVIGATION_CONTROLLER_IMPL_H_