components/url_matcher/url_matcher_factory_unittest.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_matcher/url_matcher_factory_unittest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/about_sync_util.cc ('k') | content/browser/geolocation/network_location_provider_unittest.cc » ('j') | dbus/values_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/url_matcher/url_matcher_factory_unittest.cc

diff --git a/components/url_matcher/url_matcher_factory_unittest.cc b/components/url_matcher/url_matcher_factory_unittest.cc

index 77f7a04e8c9f7e68512c0fcdc88c0812802104c3..22f200f477f46d7f389f13abe4f82ebfbc4ec050 100644

--- a/components/url_matcher/url_matcher_factory_unittest.cc

+++ b/components/url_matcher/url_matcher_factory_unittest.cc

@@ -6,6 +6,9 @@

#include <stddef.h>

+#include <memory>

+#include <utility>

#include "base/format_macros.h"

#include "base/macros.h"

#include "base/strings/stringprintf.h"

@@ -49,12 +52,12 @@ TEST(URLMatcherFactoryTest, CreateFromURLFilterDictionary) {

// }

// Port range: Allow 80;1000-1010.

- base::ListValue* port_range = new base::ListValue();

+ std::unique_ptr<base::ListValue> port_range(new base::ListValue());

port_range->AppendInteger(1000);

port_range->AppendInteger(1010);

base::ListValue* port_ranges = new base::ListValue();

port_ranges->AppendInteger(80);

- port_ranges->Append(port_range);

+ port_ranges->Append(std::move(port_range));

base::ListValue* scheme_list = new base::ListValue();

scheme_list->AppendString("http");