Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <stddef.h>
 
 #include <set>
+#include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/i18n/number_formatting.h"
 #include "base/macros.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
@@ skipping 1205 matching lines @@
 
   int default_index = -1;
   base::ListValue search_engines;
   TemplateURLService::TemplateURLVector model_urls(
       template_url_service_->GetTemplateURLs());
   for (size_t i = 0; i < model_urls.size(); ++i) {
     if (!model_urls[i]->ShowInDefaultList(
             template_url_service_->search_terms_data()))
       continue;
 
-    base::DictionaryValue* entry = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
     entry->SetString("name", model_urls[i]->short_name());
     entry->SetInteger("index", i);
-    search_engines.Append(entry);
+    search_engines.Append(std::move(entry));
     if (model_urls[i] == default_url)
       default_index = i;
   }
 
   web_ui()->CallJavascriptFunctionUnsafe(
       "BrowserOptions.updateSearchEngines", search_engines,
       base::FundamentalValue(default_index),
       base::FundamentalValue(
           template_url_service_->is_default_search_managed() ||
           template_url_service_->IsExtensionControlledDefaultSearch()));
@@ skipping 99 matching lines @@
       g_browser_process->profile_manager()->
       GetProfileAttributesStorage().GetAllProfilesAttributesSortedByName();
   std::unique_ptr<base::ListValue> profile_info_list(new base::ListValue);
   base::FilePath current_profile_path =
       web_ui()->GetWebContents()->GetBrowserContext()->GetPath();
 
   for (const ProfileAttributesEntry* entry : entries) {
     // The items in |profile_value| are also described in
     // chrome/browser/resources/options/browser_options.js in a @typedef for
     // Profile. Please update it whenever you add or remove any keys here.
-    base::DictionaryValue* profile_value = new base::DictionaryValue();
+    std::unique_ptr<base::DictionaryValue> profile_value(
+        new base::DictionaryValue());
     profile_value->SetString("name", entry->GetName());
     base::FilePath profile_path = entry->GetPath();
     profile_value->Set("filePath", base::CreateFilePathValue(profile_path));
     profile_value->SetBoolean("isCurrentProfile",
                               profile_path == current_profile_path);
     profile_value->SetBoolean("isSupervised", entry->IsSupervised());
     profile_value->SetBoolean("isChild", entry->IsChild());
 
     if (entry->IsUsingGAIAPicture() && entry->GetGAIAPicture()) {
       gfx::Image icon = profiles::GetAvatarIconForWebUI(entry->GetAvatarIcon(),
                                                         true);
       profile_value->SetString("iconURL",
                                webui::GetBitmapDataUrl(icon.AsBitmap()));
     } else {
       size_t icon_index = entry->GetAvatarIconIndex();
       profile_value->SetString("iconURL",
                                profiles::GetDefaultAvatarIconUrl(icon_index));
     }
 
-    profile_info_list->Append(profile_value);
+    profile_info_list->Append(std::move(profile_value));
   }
 
   return profile_info_list;
 }
 
 void BrowserOptionsHandler::SendProfilesInfo() {
   if (!ShouldShowMultiProfilesUserList())
     return;
   web_ui()->CallJavascriptFunctionUnsafe("BrowserOptions.setProfilesInfo",
                                          *GetProfilesInfoList());
@@ skipping 608 matching lines @@
 
   // Iterate through the zoom factors and and build the contents of the
   // selector that will be sent to the javascript handler.
   // Each item in the list has the following parameters:
   // 1. Title (string).
   // 2. Value (double).
   // 3. Is selected? (bool).
   base::ListValue zoom_factors_value;
   for (std::vector<double>::const_iterator i = zoom_factors.begin();
        i != zoom_factors.end(); ++i) {
-    base::ListValue* option = new base::ListValue();
+    std::unique_ptr<base::ListValue> option(new base::ListValue());
     double factor = *i;
     int percent = static_cast<int>(factor * 100 + 0.5);
     option->AppendString(base::FormatPercent(percent));
     option->AppendDouble(factor);
     bool selected = content::ZoomValuesEqual(factor, default_zoom_factor);
     option->AppendBoolean(selected);
-    zoom_factors_value.Append(option);
+    zoom_factors_value.Append(std::move(option));
   }
 
   web_ui()->CallJavascriptFunctionUnsafe("BrowserOptions.setupPageZoomSelector",
                                          zoom_factors_value);
 }
 
 void BrowserOptionsHandler::SetupAutoOpenFileTypes() {
   // Set the hidden state for the AutoOpenFileTypesResetToDefault button.
   // We show the button if the user has any auto-open file types registered.
   DownloadManager* manager = BrowserContext::GetDownloadManager(
@@ skipping 159 matching lines @@
 
 bool BrowserOptionsHandler::IsDeviceOwnerProfile() {
 #if defined(OS_CHROMEOS)
   return chromeos::ProfileHelper::IsOwnerProfile(Profile::FromWebUI(web_ui()));
 #else
   return true;
 #endif
 }
 
 }  // namespace options