Issue 205823002: Oilpan: Prepare to move AbstractSQLStatementBackend and SQLStatementBackend to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205823002: Oilpan: Prepare to move AbstractSQLStatementBackend and SQLStatementBackend to Oilpan heap. (Closed)

Created:
6 years, 9 months ago by tkent

Modified:
6 years, 9 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Prepare to move AbstractSQLStatementBackend and SQLStatementBackend to Oilpan heap. They are ThreadSafeRefCounted because an object is created in a context thread, is enqueued into a SQLTransactionBackend, the SQLTransactionBackend is moved to a database thread, then the database thread takes a SQLStatementBackend in the queue. We don't need to care about it in Oilpan. SQLTransactionBackend is correctly transferred with CrossThreadPersistent. BUG=347902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169622

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -11 lines)			Patch
M	Source/modules/webdatabase/AbstractSQLStatementBackend.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/modules/webdatabase/SQLStatementBackend.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/modules/webdatabase/SQLStatementBackend.cpp	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionBackend.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionBackend.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/205823002/1

6 years, 9 months ago (2014-03-20 05:04:36 UTC) #4

Message was sent while issue was closed.

LGTM2

Expand Messages | Collapse Messages