Issue 2058203002: MD User Manager: Supervised user logic should be inside ENABLE_SUPERVISED_USERS flag

Issue 2058203002: MD User Manager: Supervised user logic should be inside ENABLE_SUPERVISED_USERS flag (Closed)

Created:
4 years, 6 months ago by Moe

Modified:
4 years, 6 months ago

Reviewers:
Bernhard Bauer, Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, tfarina, pam+watch_chromium.org, Bernhard Bauer

Base URL:
https://chromium.googlesource.com/chromium/src.git@md-user-manager-policy-prefs

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

MD User Manager: Supervised user logic should be inside ENABLE_SUPERVISED_USERS flag BUG=563722 Committed: https://crrev.com/40b19fe09cf47bd2b99f59dc838a94630d7da517 Cr-Commit-Position: refs/heads/master@{#399996}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -42 lines)			Patch
M	chrome/browser/ui/webui/signin/signin_create_profile_handler.h	View	9 chunks	+22 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/webui/signin/signin_create_profile_handler.cc	View	3 chunks	+12 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc	View	10 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	2 chunks	+5 lines, -1 line	0 comments	Download

Depends on Patchset:

Total messages: 12 (4 generated)

Moe

Hi Roger, Please take a look at this CL. It simply reorganizes the code so ...

4 years, 6 months ago (2016-06-10 19:56:51 UTC) #2

Roger Tawa OOO till Jul 10th

lgtm, let's see what Bernhard thinks.

4 years, 6 months ago (2016-06-14 15:33:28 UTC) #5

Moe

On 2016/06/15 14:54:22, Bernhard Bauer wrote: > LGTM, thanks! Thank you.

4 years, 6 months ago (2016-06-15 18:41:57 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058203002/1

4 years, 6 months ago (2016-06-15 18:42:27 UTC) #9

commit-bot: I haz the power

4 years, 6 months ago (2016-06-15 20:19:06 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/40b19fe09cf47bd2b99f59dc838a94630d7da517
Cr-Commit-Position: refs/heads/master@{#399996}