Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture

Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture

Switch to new SkSourceGammaTreatment type. Move to a separate setter,
rather than an optional argument to dirty. Set the flag correctly after
uploading CPU-built mips.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058143002

Committed: https://skia.googlesource.com/skia/+/fe19987e5499650e8637a8d109f19b8156601660

[Brian Osman, 2016-06-10 17:08:56]

Description was changed from

==========
Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture

Switch to new SkSourceGammaTreatment type. Move to a separate setter,
rather than an optional argument to dirty. Set the flag correctly after
uploading CPU-built mips.

BUG=skia:
==========

to

==========
Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture

Switch to new SkSourceGammaTreatment type. Move to a separate setter,
rather than an optional argument to dirty. Set the flag correctly after
uploading CPU-built mips.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058143002
==========

[Brian Osman, 2016-06-10 17:09:10]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 17:09:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058143002/1

[commit-bot: I haz the power, 2016-06-10 17:23:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 17:23:44]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-06-13 13:56:17]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 13:56:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058143002/20001

[Brian Osman, 2016-06-13 13:59:20]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com, reed@google.com

[bsalomon, 2016-06-13 14:03:04]

I don't think this is a safe way of tracking the gamma state. You could (in
theory) queue up two draws reading from the same texture. Assuming no flush
between the recording of the draws, the second draw's gamma state would
overwrite the firsts. I think the right place to track this is on
GrTextureAccess or GrTextureParams.

[commit-bot: I haz the power, 2016-06-13 14:10:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 14:10:07]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-06-13 14:39:37]

On 2016/06/13 14:03:04, bsalomon wrote:
> I don't think this is a safe way of tracking the gamma state. You could (in
> theory) queue up two draws reading from the same texture. Assuming no flush
> between the recording of the draws, the second draw's gamma state would
> overwrite the firsts. I think the right place to track this is on
> GrTextureAccess or GrTextureParams.

My understanding is that GrGenerateMipsAndUploadToTexture will happen at most
once for a particular texture (it's a factory). After that, any changes to this
state will happen on the GPU, pipelined with updates to this state.

[bsalomon, 2016-06-13 14:52:44]

On 2016/06/13 14:39:37, Brian Osman wrote:
> On 2016/06/13 14:03:04, bsalomon wrote:
> > I don't think this is a safe way of tracking the gamma state. You could (in
> > theory) queue up two draws reading from the same texture. Assuming no flush
> > between the recording of the draws, the second draw's gamma state would
> > overwrite the firsts. I think the right place to track this is on
> > GrTextureAccess or GrTextureParams.
> 
> My understanding is that GrGenerateMipsAndUploadToTexture will happen at most
> once for a particular texture (it's a factory). After that, any changes to
this
> state will happen on the GPU, pipelined with updates to this state.

Ok, looking more closely at the GrGLGpu.cpp, I get it. lgtm.

[Brian Osman, 2016-06-13 14:58:50]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-06-13 14:58:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058143002/20001

[commit-bot: I haz the power, 2016-06-13 14:59:50]

Description was changed from

==========
Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture

Switch to new SkSourceGammaTreatment type. Move to a separate setter,
rather than an optional argument to dirty. Set the flag correctly after
uploading CPU-built mips.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058143002
==========

to

==========
Better (?) interface for controlling sRGB-ness of mipmaps on GrTexture

Switch to new SkSourceGammaTreatment type. Move to a separate setter,
rather than an optional argument to dirty. Set the flag correctly after
uploading CPU-built mips.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2058143002

Committed:
https://skia.googlesource.com/skia/+/fe19987e5499650e8637a8d109f19b8156601660
==========

[commit-bot: I haz the power, 2016-06-13 14:59:52]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fe19987e5499650e8637a8d109f19b8156601660