third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h - Issue 2058133002: Fix DevTools support of worklets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

Issue 2058133002: Fix DevTools support of worklets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move frame extraction logic to BindingSecurity Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp » ('j') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

index ba696d11f440bc4c8a593d0f3622e2d1c033b608..fcf9878c6b73836a32aa754a73272dfdb5945f77 100644

--- a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

+++ b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

@@ -32,6 +32,7 @@

#define BindingSecurity_h

#include "core/CoreExport.h"

+#include "core/dom/ExecutionContext.h"

#include "wtf/Allocator.h"

#include <v8.h>

@@ -72,7 +73,7 @@ public:

static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Location* target, ExceptionState&);

static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Location* target, SecurityReportingOption);

// MainThreadWorkletGlobalScope

- static bool shouldAllowAccessTo(v8::Isolate*, const LocalDOMWindow* accessingWindow, const MainThreadWorkletGlobalScope* target, SecurityReportingOption);

+ static bool shouldAllowAccessTo(v8::Isolate*, const v8::Local<v8::Context>&, const ExecutionContext*, const MainThreadWorkletGlobalScope* target, SecurityReportingOption);

// Prefer to use the previous overloads instead of falling back to using

// Frame*.

static bool shouldAllowAccessToFrame(v8::Isolate*, const LocalDOMWindow* accessingWindow, const Frame* target, SecurityReportingOption); // OBSOLETE