Fix DevTools support of worklets

third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

 /*
  * Copyright (c) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 94 matching lines @@
     DCHECK(isMainThread());
     if (frame->localFrameRoot() == frame)
         debugger()->resetContextGroup(contextGroupId(frame));
 }
 
 void MainThreadDebugger::contextCreated(ScriptState* scriptState, LocalFrame* frame, SecurityOrigin* origin)
 {
     ASSERT(isMainThread());
     v8::HandleScope handles(scriptState->isolate());
     DOMWrapperWorld& world = scriptState->world();
+    DLOG(WARNING) << toDOMWindow(scriptState->isolate()->GetCallingContext());
     debugger()->contextCreated(V8ContextInfo(scriptState->context(), contextGroupId(frame), world.isMainWorld(), origin ? origin->toRawString() : "", world.isIsolatedWorld() ? world.isolatedWorldHumanReadableName() : "", IdentifiersFactory::frameId(frame), scriptState->getExecutionContext()->isDocument()));
 }
 
 void MainThreadDebugger::contextWillBeDestroyed(ScriptState* scriptState)
 {
     v8::HandleScope handles(scriptState->isolate());
     debugger()->contextDestroyed(scriptState->context());
 }
 
 int MainThreadDebugger::contextGroupId(LocalFrame* frame)
@@ skipping 62 matching lines @@
     FrameConsole::unmute();
 }
 
 bool MainThreadDebugger::callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target)
 {
     ExecutionContext* executionContext = toExecutionContext(target);
     ASSERT(executionContext);
 
     if (executionContext->isMainThreadWorkletGlobalScope()) {
         MainThreadWorkletGlobalScope* globalScope = toMainThreadWorkletGlobalScope(executionContext);
-        return globalScope && BindingSecurity::shouldAllowAccessTo(m_isolate, toLocalDOMWindow(toDOMWindow(calling)), globalScope, DoNotReportSecurityError);
+        DLOG(WARNING) << toLocalDOMWindow(toDOMWindow(calling));
+        DLOG(WARNING) << toLocalDOMWindow(toDOMWindow(target));
+        if (globalScope) {

[dgozman, 2016/06/24 22:03:15]

This code only runs if |target| is a worklet. You should move it outside of if
statement.

[Gleb Lanbin, 2016/06/25 00:17:26]

not sure if it helps. In my case when I stop inside of the worklet |calling| is
the context of my worklet function that doesn't have DOM window associated with
it and I'm not sure what is the |target| in my case. I think |target| is my main
CSS paint function defined in CSSPaintDefinition.cpp. It doesn't have DOM window
as well.

Maybe I should just verify that |target| and |calling| are running in
MainThreadWorkletGlobalScope execution context and let it go?
Something like

if (toExecutionContext(target).isMainThreadWorkletGlobalScope() &&
toExecutionContext(calling).isMainThreadWorkletGlobalScope()) return true;
what do you think?

[dgozman, 2016/06/27 21:16:41]

Take a look at how BindingSecurity::shouldAllowAccessTo retrieves a frame and
then DOM window from a worklet.
No, in this case we should check that worklets are from the frames which can
script each other.
We cannot skip security checks.

+            bool isAllowedToWorklet = BindingSecurity::shouldAllowAccessTo(m_isolate, toLocalDOMWindow(toDOMWindow(calling)), globalScope, DoNotReportSecurityError);
+            bool isAllowedFromWorklet = BindingSecurity::shouldAllowAccessTo(m_isolate, toLocalDOMWindow(toDOMWindow(target)), globalScope, DoNotReportSecurityError);
+            return isAllowedToWorklet || isAllowedFromWorklet;
+        }
+        return false;
     }
 
     DOMWindow* window = toDOMWindow(target);
     return window && BindingSecurity::shouldAllowAccessTo(m_isolate, toLocalDOMWindow(toDOMWindow(calling)), window, DoNotReportSecurityError);
 }
 
 int MainThreadDebugger::ensureDefaultContextInGroup(int contextGroupId)
 {
     LocalFrame* frame = WeakIdentifierMap<LocalFrame>::lookup(contextGroupId);
     if (!frame)
@@ skipping 131 matching lines @@
                 return;
             if (!nodes->Set(context, index++, toV8(node, info.Holder(), info.GetIsolate())).FromMaybe(false))
                 return;
         }
         info.GetReturnValue().Set(nodes);
     }
     exceptionState.throwIfNeeded();
 }
 
 } // namespace blink