Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 205813004: crypto.gyp: move openssl dependency into use_openssl section. Remove redundant source excludes. (Closed)

Created:
6 years, 9 months ago by mattm
Modified:
6 years, 9 months ago
Reviewers:
wtc, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

crypto.gyp: move openssl dependency into use_openssl section. Remove redundant source excludes. BUG=338888 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M crypto/crypto.gyp View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mattm
The thing we chatted about.
6 years, 9 months ago (2014-03-20 02:08:10 UTC) #1
wtc
Patch set 1 LGTM.
6 years, 9 months ago (2014-03-20 23:52:09 UTC) #2
mattm
The CQ bit was checked by mattm@chromium.org
6 years, 9 months ago (2014-03-21 19:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/205813004/1
6 years, 9 months ago (2014-03-21 19:31:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 23:27:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=286213
6 years, 9 months ago (2014-03-21 23:27:00 UTC) #6
mattm
The CQ bit was checked by mattm@chromium.org
6 years, 9 months ago (2014-03-21 23:27:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/205813004/1
6 years, 9 months ago (2014-03-21 23:28:31 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 03:01:27 UTC) #9
Message was sent while issue was closed.
Change committed as 258749

Powered by Google App Engine
This is Rietveld 408576698