Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2058053002: Revert of Convert fast/repaint/window-resize*.html into reftests (Closed)

Created:
4 years, 6 months ago by perkj_chrome
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert fast/repaint/window-resize*.html into reftests (patchset #7 id:120001 of https://codereview.chromium.org/2039943003/ ) Reason for revert: This cl seem to cause layout test failures on Win and Mac blink bots. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5972 Original issue's description: > Convert fast/repaint/window-resize*.html into reftests > > to make rect under-invalidations more visible, and show > painting/rasterization errors if any. > > BUG=600008 > > Committed: https://crrev.com/c612643f5283dc92d261ca2b359e918b8b9343e4 > Cr-Commit-Position: refs/heads/master@{#399007} TBR=pdr@chromium.org,chrishtr@chromium.org,enne@chromium.org,wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+812 lines, -1555 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js View 1 chunk +28 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 4 chunks +26 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-expected.txt View 4 chunks +32 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-generated-expected.txt View 4 chunks +32 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 4 chunks +26 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-media-query-expected.txt View 3 chunks +31 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change1-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-no-layout-change2-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-html-expected.txt View 4 chunks +36 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-percent-width-height-expected.txt View 4 chunks +18 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-bottom-expected.txt View 2 chunks +65 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-positioned-percent-top-expected.txt View 2 chunks +65 lines, -70 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-vertical-writing-mode.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-vertical-writing-mode-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/window-resize-viewport-percent-expected.txt View 4 chunks +18 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-centered-inline-under-fixed-pos-expected.txt View 3 chunks +174 lines, -206 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-vertical-writing-mode-expected.txt View 1 chunk +255 lines, -781 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
perkj_chrome
Created Revert of Convert fast/repaint/window-resize*.html into reftests
4 years, 6 months ago (2016-06-10 11:11:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2058053002/1
4 years, 6 months ago (2016-06-10 11:11:15 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-10 11:12:46 UTC) #5
perkj_chrome
I will disable the failing tests instead.
4 years, 6 months ago (2016-06-10 13:36:10 UTC) #6
Xianzhu
On 2016/06/10 13:36:10, perkj_chrome wrote: > I will disable the failing tests instead. Please don't ...
4 years, 6 months ago (2016-06-10 17:11:53 UTC) #8
Xianzhu
4 years, 6 months ago (2016-06-10 17:12:44 UTC) #9
Message was sent while issue was closed.
Thanks for marking the tests failure. I'm investigating them.

Powered by Google App Engine
This is Rietveld 408576698