Chromium Code Reviews| Index: media/mojo/services/BUILD.gn |
| diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn |
| index 89e45dafaad8bdf3189b9244084f5f9e67f4258a..38e2c8f69409913523947803702af129a17e58f5 100644 |
| --- a/media/mojo/services/BUILD.gn |
| +++ b/media/mojo/services/BUILD.gn |
| @@ -72,16 +72,19 @@ source_set("proxy") { |
| public_configs = [ ":mojo_media_config" ] |
| - deps = [ |
| + public_deps = [ |
|
xhwang
2016/06/10 19:49:56
why are these public_deps now?
Ken Rockot(use gerrit already)
2016/06/10 20:00:41
Because they're exposed by headers like mojo_decry
xhwang
2016/06/10 20:05:52
That makes me sad. Having to track what should be
|
| "//base", |
| "//media", |
| - "//media/mojo/common", |
| "//media/mojo/interfaces", |
| - "//mojo/common", |
| - "//mojo/public/c/system:for_component", |
| - "//services/shell/public/cpp:sources", |
| + "//mojo/public/cpp/bindings", |
| + "//mojo/public/cpp/system", |
| "//services/shell/public/interfaces", |
| - "//ui/gfx/geometry/mojo", |
| + ] |
| + |
| + deps = [ |
| + "//media/mojo/common", |
| + "//mojo/common", |
| + "//services/shell/public/cpp", |
| ] |
| } |
| @@ -126,20 +129,22 @@ component("services") { |
| configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] |
| public_configs = [ ":mojo_media_config" ] |
| - deps = [ |
| + public_deps = [ |
| "//base", |
| "//media", |
| + "//media/mojo/interfaces", |
| + "//mojo/public/cpp/bindings", |
| + "//mojo/public/cpp/system", |
| + "//services/shell/public/cpp", |
| + "//url", |
| + ] |
| + |
| + deps = [ |
| "//media:cdm_api", |
| "//media:shared_memory_support", |
| "//media/mojo/common", |
| - "//media/mojo/interfaces", |
| "//mojo/common", |
| - "//mojo/public/c/system:for_component", |
| - "//services/shell/public/cpp", |
| - "//services/shell/public/cpp:sources", |
| "//services/shell/public/interfaces", |
| - "//ui/gfx/geometry/mojo", |
| - "//url", |
| ] |
| if (is_android) { |
| @@ -177,12 +182,14 @@ mojo_native_application("media") { |
| "test_mojo_media_client.h", |
| ] |
| - deps = [ |
| + public_deps = [ |
| ":services", |
| "//base", |
| "//media", |
| - "//mojo/public/c/system:for_shared_library", |
| - "//services/shell/public/cpp:sources", |
| + ] |
| + |
| + deps = [ |
| + "//mojo/public/c/system", |
| ] |
| } |