Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2057993003: Serialize NativeBehavior for elements (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Serialize NativeBehavior for elements - Serialize nativeMethodBehavior, nativeFieldLoadBehavior and nativeFieldStoreBehavior. - Add a test for the serialization/deserialization of native data for dart:html. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/364f84f05dd944782f642767b659dec048ee9c5f

Patch Set 1 #

Patch Set 2 : dartfmt #

Patch Set 3 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -217 lines) Patch
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 1 4 chunks +87 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 3 chunks +39 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/compilation_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 1 2 1 chunk +28 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 1 2 2 chunks +0 lines, -123 lines 0 comments Download
A tests/compiler/dart2js/serialization/native_data_test.dart View 1 2 1 chunk +100 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 5 chunks +129 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 6 months ago (2016-06-10 08:05:38 UTC) #2
Johnni Winther
ping
4 years, 6 months ago (2016-06-15 07:35:52 UTC) #3
Harry Terkelsen
lgtm lgtm!
4 years, 6 months ago (2016-06-15 17:47:59 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-06-16 06:52:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
364f84f05dd944782f642767b659dec048ee9c5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698