Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2057953002: Revert of Re-enable DexLoaderTests (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
Xi Han, pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable DexLoaderTests (patchset #1 id:1 of https://codereview.chromium.org/2056783002/ ) Reason for revert: Still red on the debug bot :( https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/34786 Original issue's description: > Re-enable DexLoaderTests > > https://codereview.chromium.org/2045313002/ fixed the bug with dx --incremental > causing the DexLoaderTests to fail on partial rebuilds of chrome_public_test_apk > > BUG=617935 > > Committed: https://crrev.com/ab92c217cd5792ea92b9e52d2dc65d03992b6f68 > Cr-Commit-Position: refs/heads/master@{#399023} TBR=hanxi@chromium.org,pkotwicz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617935 Committed: https://crrev.com/2155e5ec527a8dace3a2aa3dd5f331c36fe8d255 Cr-Commit-Position: refs/heads/master@{#399072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of Re-enable DexLoaderTests
4 years, 6 months ago (2016-06-10 03:18:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057953002/1
4 years, 6 months ago (2016-06-10 03:18:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 03:20:51 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 03:23:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2155e5ec527a8dace3a2aa3dd5f331c36fe8d255
Cr-Commit-Position: refs/heads/master@{#399072}

Powered by Google App Engine
This is Rietveld 408576698