chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java - Issue 2057933002: [Custom Tabs] Navigate to other apps if the first url is a redirect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

Issue 2057933002: [Custom Tabs] Navigate to other apps if the first url is a redirect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

index 3c13687db2e1666fd2df8df9121b0a6913cd0716..08509ab4fff95421501d27a50cce2f5d2b620b80 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

@@ -12,7 +12,6 @@ import android.support.customtabs.CustomTabsService;

import android.support.customtabs.CustomTabsSessionToken;

import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;

-import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

import java.util.List;

@@ -27,7 +26,6 @@ public class CustomTabsConnectionService extends CustomTabsService {

boolean firstRunNecessary = FirstRunFlowSequencer

.checkIfFirstRunIsNecessary(getApplicationContext(), false) != null;

if (firstRunNecessary) return null;

- if (!ChromePreferenceManager.getInstance(this).getCustomTabsEnabled()) return null;

mConnection = CustomTabsConnection.getInstance(getApplication());

mConnection.logCall("Service#onBind()", true);

return super.onBind(intent);