Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 2057903003: Capture instantiator in async function when required to check result type. (Closed)

Created:
4 years, 6 months ago by regis
Modified:
4 years, 6 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Capture instantiator in async function when required to check result type. Add regression test (fixes #26668). Committed: https://github.com/dart-lang/sdk/commit/f4029bf3ee72c6667f4099a0e2e747b22fe45c32

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -31 lines) Patch
M runtime/vm/parser.cc View 2 chunks +44 lines, -31 lines 0 comments Download
A tests/language/regress_26668_test.dart View 1 chunk +18 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
regis
TBR, since I have a vacation day on Friday.
4 years, 6 months ago (2016-06-10 02:12:39 UTC) #2
regis
Committed patchset #1 (id:1) manually as f4029bf3ee72c6667f4099a0e2e747b22fe45c32 (presubmit successful).
4 years, 6 months ago (2016-06-10 02:14:19 UTC) #4
hausner
LGTM
4 years, 6 months ago (2016-06-10 17:23:29 UTC) #5
hausner
PS https://codereview.chromium.org/2057903003/diff/1/tests/language/regress_26668_test.dart File tests/language/regress_26668_test.dart (right): https://codereview.chromium.org/2057903003/diff/1/tests/language/regress_26668_test.dart#newcode4 tests/language/regress_26668_test.dart:4: // Tests that the VM does not crash ...
4 years, 6 months ago (2016-06-10 17:24:56 UTC) #6
regis
4 years, 6 months ago (2016-06-13 18:18:05 UTC) #7
Message was sent while issue was closed.
On 2016/06/10 17:24:56, hausner wrote:
> PS
> 
>
https://codereview.chromium.org/2057903003/diff/1/tests/language/regress_2666...
> File tests/language/regress_26668_test.dart (right):
> 
>
https://codereview.chromium.org/2057903003/diff/1/tests/language/regress_2666...
> tests/language/regress_26668_test.dart:4: // Tests that the VM does not crash
on
> weird corner cases of class Math.
> Comment is probably a left-over from another test. I'll fix it in a separate
CL.

This same stray comment shows up in 3 different tests :-)
I'll send a cl. Thanks!

Powered by Google App Engine
This is Rietveld 408576698