Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2057883002: Add a gRPC repository to DEPS to fetch for Linux platform. (Closed)

Created:
4 years, 6 months ago by xyzzyz
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a gRPC repository to DEPS to fetch for Linux platform. Adding gRPC was approved by Chrome Eng Review, as long as it is used only by Blimp, which we plan to enforce by fetching it only on Linux, setting up visibility rules in BUILD.gn files, and checkdeps. gRPC was approved by open-source-third-party-reviews@google.com. BUG=618889 Committed: https://crrev.com/082e79e5c5dc5c50349c4b42076a97a39bc27ae4 Cr-Commit-Position: refs/heads/master@{#400742}

Patch Set 1 #

Patch Set 2 : checklicenses #

Total comments: 1

Patch Set 3 : checlicense bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
xyzzyz
4 years, 6 months ago (2016-06-10 19:45:39 UTC) #4
Nico
lgtm
4 years, 6 months ago (2016-06-10 20:05:23 UTC) #5
brettw
lgtm
4 years, 6 months ago (2016-06-10 21:00:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057883002/1
4 years, 6 months ago (2016-06-10 21:32:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/176139)
4 years, 6 months ago (2016-06-10 22:45:13 UTC) #10
Paweł Hajdan Jr.
https://codereview.chromium.org/2057883002/diff/20001/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/2057883002/diff/20001/tools/checklicenses/checklicenses.py#newcode390 tools/checklicenses/checklicenses.py:390: 'third_party/grpc': [ # http://crbug.com/620837 Please file an upstream bug ...
4 years, 6 months ago (2016-06-17 09:48:26 UTC) #12
xyzzyz
On 2016/06/17 09:48:26, Paweł Hajdan Jr. wrote: > https://codereview.chromium.org/2057883002/diff/20001/tools/checklicenses/checklicenses.py > File tools/checklicenses/checklicenses.py (right): > > ...
4 years, 6 months ago (2016-06-17 19:02:50 UTC) #13
Paweł Hajdan Jr.
LGTM
4 years, 6 months ago (2016-06-20 09:44:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2057883002/40001
4 years, 6 months ago (2016-06-20 17:45:14 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-20 18:59:42 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 19:03:35 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/082e79e5c5dc5c50349c4b42076a97a39bc27ae4
Cr-Commit-Position: refs/heads/master@{#400742}

Powered by Google App Engine
This is Rietveld 408576698