Opens the HaTS dialog with an empty HTML

Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1a8f89a70054c8a7d8d45433e1126a10ef9b54f6
Cr-Commit-Position: refs/heads/master@{#399269}

[malaykeshav, 2016-06-09 23:01:05]

Description was changed from

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources

Implements an empty hats dialog

Displays an empty hats dialog when the user clicks on 'Take Survey' in
the notification.

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS
==========

to

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources

Implements an empty hats dialog

Displays an empty hats dialog when the user clicks on 'Take Survey' in
the notification.

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[malaykeshav, 2016-06-09 23:11:24]

Patchset #1 (id:1) has been deleted

[malaykeshav, 2016-06-09 23:11:36]

Description was changed from

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources

Implements an empty hats dialog

Displays an empty hats dialog when the user clicks on 'Take Survey' in
the notification.

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
==========

[malaykeshav, 2016-06-09 23:12:19]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 23:12:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057853002/20001

[malaykeshav, 2016-06-10 00:55:00]

malaykeshav@chromium.org changed reviewers:
+ jdufault@chromium.org

[malaykeshav, 2016-06-10 00:55:14]

malaykeshav@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-06-10 01:08:17]

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/hats/hats_dialog.cc (right):

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/hats/hats_dialog.cc:49: return
GURL(base::StringPrintf("%s", chrome::kChromeUIHatsURL));
GURL(chrome::kChromeUIHatsURL) ?

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/hats/hats_ui.cc (right):

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.cc:28:
base::Bind(&HatsUI::SurveyCompleted, base::Unretained(this)));
We should at least add a "complete survey" button that calls this initially (or
omit this until we call it).

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.cc:30: Profile* profile =
Profile::FromWebUI(web_ui);
No need for local

[commit-bot: I haz the power, 2016-06-10 01:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:14:56]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[malaykeshav, 2016-06-10 01:18:20]

Description was changed from

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
==========

to

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[malaykeshav, 2016-06-10 01:18:33]

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/hats/hats_dialog.cc (right):

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/hats/hats_dialog.cc:49: return
GURL(base::StringPrintf("%s", chrome::kChromeUIHatsURL));
On 2016/06/10 at 01:08:16, stevenjb wrote:
> GURL(chrome::kChromeUIHatsURL) ?

Done

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/hats/hats_ui.cc (right):

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.cc:28:
base::Bind(&HatsUI::SurveyCompleted, base::Unretained(this)));
On 2016/06/10 at 01:08:16, stevenjb wrote:
> We should at least add a "complete survey" button that calls this initially
(or omit this until we call it).

Done. Removing for this CL.

https://codereview.chromium.org/2057853002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.cc:30: Profile* profile =
Profile::FromWebUI(web_ui);
On 2016/06/10 at 01:08:16, stevenjb wrote:
> No need for local

Done

[malaykeshav, 2016-06-10 01:20:04]

malaykeshav@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2016-06-10 16:08:29]

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/hats/hats_ui.cc (right):

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.cc:7: #include "base/values.h"
nit: not used?

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/hats/hats_ui.h (right):

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.h:16: class
BluetoothOptionsHandler;
nit: not used?

[malaykeshav, 2016-06-10 17:52:19]

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/hats/hats_ui.cc (right):

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.cc:7: #include "base/values.h"
On 2016/06/10 at 16:08:29, xiyuan wrote:
> nit: not used?

done

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/hats/hats_ui.h (right):

https://codereview.chromium.org/2057853002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/hats/hats_ui.h:16: class
BluetoothOptionsHandler;
On 2016/06/10 at 16:08:29, xiyuan wrote:
> nit: not used?

done

[xiyuan, 2016-06-10 17:57:22]

lgtm

[malaykeshav, 2016-06-10 17:59:18]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 17:59:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057853002/60001

[jdufault, 2016-06-10 18:17:47]

lgtm

[commit-bot: I haz the power, 2016-06-10 19:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 19:18:12]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-06-10 20:44:41]

lgtm

[malaykeshav, 2016-06-10 21:08:48]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2016-06-10 21:09:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057853002/60001

[commit-bot: I haz the power, 2016-06-10 21:15:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-10 21:15:50]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 21:18:29]

Description was changed from

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Opens the HaTS dialog with an empty HTML

Design Doc=go/cros-hats-eng
BUG=611781
COMPONENT=Chrome OS, HaTS, WebUI, Resources
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1a8f89a70054c8a7d8d45433e1126a10ef9b54f6
Cr-Commit-Position: refs/heads/master@{#399269}
==========

[commit-bot: I haz the power, 2016-06-10 21:18:31]

Patchset 3 (id:??) landed as
https://crrev.com/1a8f89a70054c8a7d8d45433e1126a10ef9b54f6
Cr-Commit-Position: refs/heads/master@{#399269}