Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Compile Errors Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index e823d37e54a3c4690e6ea6ec70442e2fb2e12bc9..429ff09e54d3eeea3f52f5c4be93fdf14797e0b7 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -141,6 +141,13 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
//----------------------------------------------------------------------------
// The following methods can be overridden by derived classes.
+ // Notifies the View that the renderer selection bounds has changed.
+ // |start_rect| and |end_rect| are the bounds end of the selection in the
+ // coordinate system of the render view. |start_direction| and |end_direction|
kenrb 2016/06/28 19:15:23 nit: "render view" here is now more correctly "ren
EhsanK 2016/06/29 17:09:58 Acknowledged.
+ // indicates the direction at which the selection was made on touch devices.
+ virtual void SelectionBoundsChanged(
+ const ViewHostMsg_SelectionBounds_Params& params);
+
// Notifies the View that the renderer text selection has changed.
virtual void SelectionChanged(const base::string16& text,
size_t offset,
@@ -296,13 +303,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// the page has changed.
virtual void SetTooltipText(const base::string16& tooltip_text) = 0;
- // Notifies the View that the renderer selection bounds has changed.
- // |start_rect| and |end_rect| are the bounds end of the selection in the
- // coordinate system of the render view. |start_direction| and |end_direction|
- // indicates the direction at which the selection was made on touch devices.
- virtual void SelectionBoundsChanged(
- const ViewHostMsg_SelectionBounds_Params& params) = 0;
-
// Copies the contents of the compositing surface, providing a new SkBitmap
// result via an asynchronously-run |callback|. |src_subrect| is specified in
// layer space coordinates for the current platform (e.g., DIP for Aura/Mac,

Powered by Google App Engine
This is Rietveld 408576698