Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2630)

Unified Diff: content/public/test/text_input_test_utils.h

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis@'s comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/text_input_manager.cc ('k') | content/public/test/text_input_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/text_input_test_utils.h
diff --git a/content/public/test/text_input_test_utils.h b/content/public/test/text_input_test_utils.h
index 92be4ae87b1d597854953b7c9aead9ef86219700..f87e9fed0fd7b7fe0c04d4c44d51e78487515e38 100644
--- a/content/public/test/text_input_test_utils.h
+++ b/content/public/test/text_input_test_utils.h
@@ -42,14 +42,16 @@ RenderWidgetHostView* GetActiveViewFromWebContents(WebContents* web_contents);
// observing the TextInputManager for WebContents.
class TextInputManagerTester {
public:
- using Callback = base::Callback<void(TextInputManagerTester*)>;
-
TextInputManagerTester(WebContents* web_contents);
virtual ~TextInputManagerTester();
// Sets a callback which is invoked when a RWHV calls UpdateTextInputState
// on the TextInputManager which is being observed.
- void SetUpdateTextInputStateCalledCallback(const Callback& callback);
+ void SetUpdateTextInputStateCalledCallback(const base::Closure& callback);
+
+ // Sets a callback which is invoked when a RWHV calls SelectionBoundsChanged
+ // on the TextInputManager which is being observed.
+ void SetOnSelectionBoundsChangedCallback(const base::Closure& callback);
// Returns true if there is a focused <input> and populates |type| with
// |TextInputState.type| of the TextInputManager.
@@ -63,9 +65,8 @@ class TextInputManagerTester {
// if none exists.
const RenderWidgetHostView* GetActiveView();
- // Returns the RenderWidgetHostView which has most recently called
- // TextInputManager::UpdateTextInputState on the TextInputManager which is
- // being observed.
+ // Returns the RenderWidgetHostView which has most recently updated any of its
+ // state (e.g., TextInputState or otherwise).
const RenderWidgetHostView* GetUpdatedView();
// Returns true if a call to TextInputManager::UpdateTextInputState has led
« no previous file with comments | « content/browser/renderer_host/text_input_manager.cc ('k') | content/public/test/text_input_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698