Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only)

content/browser/renderer_host/render_widget_host_view_base.h

Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index f6a25c17c6e18b7a5b83149f686ace8cda3fc7e5..6128aa726996c06ae5cc0f981762883816f69ff1 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -251,18 +251,27 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
                                                cc::SurfaceId original_surface,
                                                gfx::Point* transformed_point);
 
+  //----------------------------------------------------------------------------
+  // The following methods are related to IME.
+  // TODO(ekaramad): Most of the IME methods should not stay virtual after IME
+  // is implemented for OOPIF. After fixing IME, mark the corresponding methods
+  // non-virtual (https://crbug.com/578168).
+
   // Updates the state of the input method attached to the view.
-  // TODO(ekaramad): This method will not stay virtual. It will be moved up top
-  // with the other non-virtual methods after TextInputState tracking is fixed
-  // on all platforms (https://crbug.com/578168).
   virtual void TextInputStateChanged(const TextInputState& text_input_state);
 
   // Cancel the ongoing composition of the input method attached to the view.
-  // TODO(ekaramad): This method will not stay virtual. It will be moved up top
-  // with the other non-virtual methods after IME is fixed on all platforms.
-  // (https://crbug.com/578168).
   virtual void ImeCancelComposition();
 
+  // Notifies the View that the renderer selection bounds has changed.

[Charlie Reis, 2016/07/06 18:42:36]

nit: view

[EhsanK, 2016/07/06 19:15:34]

Done. I believe this is some older style as I inherited it from original
comment. This happens on some other comments as well.

+  // Selection bounds are described as a focus bound which is the current
+  // position of caret on the screen, as well as the anchor bound which is the
+  // starting position of the selection. The coordinates are with respect to
+  // RenderWidget's window's origin. Focus and anchor bound are represented as
+  // gfx::Rect.
+  virtual void SelectionBoundsChanged(
+      const ViewHostMsg_SelectionBounds_Params& params);
+
   //----------------------------------------------------------------------------
   // The following static methods are implemented by each platform.
 
@@ -299,13 +308,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
   // the page has changed.
   virtual void SetTooltipText(const base::string16& tooltip_text) = 0;
 
-  // Notifies the View that the renderer selection bounds has changed.
-  // |start_rect| and |end_rect| are the bounds end of the selection in the
-  // coordinate system of the render view. |start_direction| and |end_direction|
-  // indicates the direction at which the selection was made on touch devices.
-  virtual void SelectionBoundsChanged(
-      const ViewHostMsg_SelectionBounds_Params& params) = 0;
-
   // Copies the contents of the compositing surface, providing a new SkBitmap
   // result via an asynchronously-run |callback|. |src_subrect| is specified in
   // layer space coordinates for the current platform (e.g., DIP for Aura/Mac,