content/browser/renderer_host/render_widget_host_view_aura.h - Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2057803002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.h

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h

index 1fb97586cdea0428fddddace86510fe4051597f1..97ce4983cb70afc7582e3dea4ff96817634d0b5c 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.h

+++ b/content/browser/renderer_host/render_widget_host_view_aura.h

@@ -153,8 +153,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAura

size_t offset,

const gfx::Range& range) override;

gfx::Size GetRequestedRendererSize() const override;

- void SelectionBoundsChanged(

- const ViewHostMsg_SelectionBounds_Params& params) override;

void CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

@@ -474,6 +472,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAura

bool did_update_state) override;

void OnImeCancelComposition(TextInputManager* text_input_manager,

RenderWidgetHostViewBase* updated_view) override;

+ void OnSelectionBoundsChanged(

+ TextInputManager* text_input_manager,

+ RenderWidgetHostViewBase* updated_view) override;

// cc::BeginFrameObserver implementation.

void OnBeginFrame(const cc::BeginFrameArgs& args) override;