Tracking SelectionBounds for all RenderWidgets on the Browser Side (Aura Only)

content/browser/renderer_host/render_widget_host_view_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 123 matching lines @@
   // the list of registered views, i.e., TextInputManager is no longer tracking
   // TextInputState from this view. The RWHV should reset |text_input_manager_|
   // to nullptr.
   void DidUnregisterFromTextInputManager(TextInputManager* text_input_manager);
 
   base::WeakPtr<RenderWidgetHostViewBase> GetWeakPtr();
 
   //----------------------------------------------------------------------------
   // The following methods can be overridden by derived classes.
 
+  // Notifies the View that the renderer selection bounds has changed.
+  // |start_rect| and |end_rect| are the bounds end of the selection in the
+  // coordinate system of the render widget. |start_direction| and
+  // |end_direction| indicates the direction at which the selection was made on
+  // touch devices.
+  virtual void SelectionBoundsChanged(
+      const ViewHostMsg_SelectionBounds_Params& params);
+
   // Notifies the View that the renderer text selection has changed.
   virtual void SelectionChanged(const base::string16& text,
                                 size_t offset,
                                 const gfx::Range& range);
 
   // The requested size of the renderer. May differ from GetViewBounds().size()
   // when the view requires additional throttling.
   virtual gfx::Size GetRequestedRendererSize() const;
 
   // The size of the view's backing surface in non-DPI-adjusted pixels.
@@ skipping 99 matching lines @@
 
   // Updates the state of the input method attached to the view.
   // TODO(ekaramad): This method will not stay virtual. It will be moved up top
   // with the other non-virtual methods after TextInputState tracking is fixed
   // on all platforms (https://crbug.com/578168).
   virtual void TextInputStateChanged(const TextInputState& text_input_state);
 
   // Cancel the ongoing composition of the input method attached to the view.
   // TODO(ekaramad): This method will not stay virtual. It will be moved up top
   // with the other non-virtual methods after IME is fixed on all platforms.
   // (https://crbug.com/578168).

[Charlie Reis, 2016/06/29 20:18:37]

I'm just trying to follow the pattern-- does this TODO apply to
SelectionBoundsChanged?

[EhsanK, 2016/06/30 00:24:45]

Yes. I actually moved the method down here with the rest of them. Added the TODO
as well although it is starting to look very redundant.

So basically these information are to be collected and used again by tab's view
for IME purposes. Similar to TextInputStateChanged.

[Charlie Reis, 2016/06/30 20:27:21]

Feel free to create a separate section with the TODO for these 3 methods (and
any others as you migrate them).  Then you don't need the TODO on each one.

[EhsanK, 2016/06/30 21:01:14]

Acknowledged.

   virtual void ImeCancelComposition();
 
   //----------------------------------------------------------------------------
   // The following static methods are implemented by each platform.
 
   static void GetDefaultScreenInfo(blink::WebScreenInfo* results);
 
   //----------------------------------------------------------------------------
   // The following pure virtual methods are implemented by derived classes.
 
@@ skipping 18 matching lines @@
   virtual void RenderProcessGone(base::TerminationStatus status,
                                  int error_code) = 0;
 
   // Tells the View to destroy itself.
   virtual void Destroy() = 0;
 
   // Tells the View that the tooltip text for the current mouse position over
   // the page has changed.
   virtual void SetTooltipText(const base::string16& tooltip_text) = 0;
 
-  // Notifies the View that the renderer selection bounds has changed.
-  // |start_rect| and |end_rect| are the bounds end of the selection in the
-  // coordinate system of the render view. |start_direction| and |end_direction|
-  // indicates the direction at which the selection was made on touch devices.
-  virtual void SelectionBoundsChanged(
-      const ViewHostMsg_SelectionBounds_Params& params) = 0;
-
   // Copies the contents of the compositing surface, providing a new SkBitmap
   // result via an asynchronously-run |callback|. |src_subrect| is specified in
   // layer space coordinates for the current platform (e.g., DIP for Aura/Mac,
   // physical for Android), and is the region to be copied from this view. When
   // |src_subrect| is empty then the whole surface will be copied. The copy is
   // then scaled to a SkBitmap of size |dst_size|. If |dst_size| is empty then
   // output will be unscaled. |callback| is run with true on success,
   // false otherwise. A smaller region than |src_subrect| may be copied
   // if the underlying surface is smaller than |src_subrect|.
   virtual void CopyFromCompositingSurface(
@@ skipping 149 matching lines @@
   base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
 
   base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_