Initial commit for the Automated Installer Testing Framework.

chrome/test/mini_installer/registry_verifier.py

+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import _winreg
+
+import settings
+
+
+def VerifyRegistryEntries(entries):

[Mathieu, 2013/08/05 18:46:13]

You should have a docstring to document public functions. A one-liner is
sufficient if the function is simple (obvious param, no return value), but if
it's more complicated, you should describe the params, their type, and the
returned value.

Look for Python Style Guide, internally.

Also, try

pylint <path/to/file...>

[sukolsak, 2013/08/05 20:34:46]

Done.

+  for key, entry in entries.iteritems():
+    # TODO(sukolsak): Use unittest framework instead of prints.
+    if VerifyRegistryEntry(key, entry):
+      print "Passed"
+    else:
+      print "Failed"
+
+
+def RootKeyConstant(key):
+  if key == "HKEY_CLASSES_ROOT":
+    return _winreg.HKEY_CLASSES_ROOT
+  if key == "HKEY_CURRENT_USER":
+    return _winreg.HKEY_CURRENT_USER
+  if key == "HKEY_LOCAL_MACHINE":
+    return _winreg.HKEY_LOCAL_MACHINE
+  if key == "HKEY_USERS":
+    return _winreg.HKEY_USERS
+  # TODO(sukolsak: Use unittest framework instead of exceptions.

[Mathieu, 2013/08/05 18:46:13]

nit: missing closing parens

[sukolsak, 2013/08/05 20:34:46]

Done.

+  raise Exception("Unknown registry key")
+
+
+def VerifyRegistryEntry(key, entry):
+  expected = entry["expected"]

[Mathieu, 2013/08/05 18:46:13]

as mentioned above, for non-obvious params such as |entry|, a description is
encouraged.

[sukolsak, 2013/08/05 20:34:46]

Done.

+  # TODO(sukolsak): Debug prints to be removed later.
+  print settings.PRINT_VERIFIER_PREFIX + key,
+  if expected:
+    print "exists...",
+  else:
+    print "doesn't exist...",
+  root_key, sub_key = key.split("\\", 1)
+  try:
+    reg_key = _winreg.OpenKey(RootKeyConstant(root_key),
+                              sub_key, 0, _winreg.KEY_READ)
+  except WindowsError:
+    return not expected
+  if not expected:
+    return False
+  if "value" in entry:
+    # TODO(sukolsak): implement value
+    pass
+  return True