chrome/test/mini_installer_test/verifier.py - Issue 20578004: Initial commit for the Automated Installer Testing Framework.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/mini_installer_test/verifier.py

Issue 20578004: Initial commit for the Automated Installer Testing Framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import registry_verifier

	6

	7

	8 def Verify(property):

	9 for verifier_name, value in property.iteritems():

	10 if verifier_name == "RegistryEntries":

	11 registry_verifier.VerifyRegistryEntries(value)

	12 else:

	13 # TODO(sukolsak): implement other verifiers

	14 pass
	gab 2013/07/31 13:45:16 Fail the test in the "else" case. i.e., if someone Fail the test in the "else" case. i.e., if someone writes a .prop file with a typo in one of the properties, the test should fail instead of silently ignoring the miss-typed property. You will likely want to use the python "unittest" framework to report failures (instead of basic prints), I believe our test infrastructure already handles parsing failures from the python unittest framework. For this first CL prints are ok I'd say, but please switch to the "unittest" framework in a follow-up CL. sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/31 13:45:16, gab wrote: > Fail the test in the "else" case. i.e., if someone writes a .prop file with a > typo in one of the properties, the test should fail instead of silently ignoring > the miss-typed property. > > You will likely want to use the python "unittest" framework to report failures > (instead of basic prints), I believe our test infrastructure already handles > parsing failures from the python unittest framework. > > For this first CL prints are ok I'd say, but please switch to the "unittest" > framework in a follow-up CL. Done.
OLD	NEW

« chrome/test/mini_installer_test/test_installer.py ('K') | « chrome/test/mini_installer_test/test_installer.py ('k') | no next file » | no next file with comments »