chrome/test/mini_installer_test/settings.py - Issue 20578004: Initial commit for the Automated Installer Testing Framework.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/mini_installer_test/settings.py

Issue 20578004: Initial commit for the Automated Installer Testing Framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/mini_installer_test/registry_verifier.py ('K') | « chrome/test/mini_installer_test/registry_verifier.py ('k') | chrome/test/mini_installer_test/test_installer.py » ('j') | chrome/test/mini_installer_test/test_installer.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 PRINT_TEST_PREFIX = "Testing: "

	6 PRINT_COMMAND_PREFIX = " * Command: "
	gab 2013/07/31 13:45:16 nit: align '=' with others nit: align '=' with others sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/31 13:45:16, gab wrote: > nit: align '=' with others Done.
	7 PRINT_STATE_PREFIX = " * State: "
	gab 2013/07/31 13:45:16 Why is this a single space less than the command p Why is this a single space less than the command prefix? sukolsak 2013/07/31 18:20:30 I think they are both 4 spaces in. Show quoted text On 2013/07/31 13:45:16, gab wrote: > Why is this a single space less than the command prefix? I think they are both 4 spaces in. gab 2013/08/01 20:30:41 Ah, my bad, it's the equality signs that aren't al Show quoted text On 2013/07/31 18:20:30, sukolsak wrote: > On 2013/07/31 13:45:16, gab wrote: > > Why is this a single space less than the command prefix? > > I think they are both 4 spaces in. Ah, my bad, it's the equality signs that aren't aligned, please align them. gab 2013/08/01 20:33:21 And I see that you've down that already in the lat Show quoted text On 2013/08/01 20:30:41, gab wrote: > On 2013/07/31 18:20:30, sukolsak wrote: > > On 2013/07/31 13:45:16, gab wrote: > > > Why is this a single space less than the command prefix? > > > > I think they are both 4 spaces in. > > Ah, my bad, it's the equality signs that aren't aligned, please align them. And I see that you've down that already in the latest patchset :) -- woot!
	8 PRINT_VERIFIER_PREFIX = " - Verify that "
	gab 2013/07/31 13:45:16 To go inline with the rest of our coding style, ho To go inline with the rest of our coding style, how about having 2 spaces indent (i.e., 4 here and 2 for command/state?) sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/31 13:45:16, gab wrote: > To go inline with the rest of our coding style, how about having 2 spaces indent > (i.e., 4 here and 2 for command/state?) Done.
OLD	NEW