Initial commit for the Automated Installer Testing Framework.

chrome/test/mini_installer_test/registry_verifier.py

+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import _winreg
+import settings
+
+
+def VerifyRegistryEntries(entries):
+  for key, entry in entries.iteritems():
+    if VerifyRegistryEntry(key, entry):
+      print "Passed"
+    else:
+      print "Failed"
+
+
+def RootKeyConstant(key):
+  if key == "HKEY_CLASSES_ROOT":
+    return _winreg.HKEY_CLASSES_ROOT
+  if key == "HKEY_CURRENT_USER":
+    return _winreg.HKEY_CURRENT_USER
+  if key == "HKEY_LOCAL_MACHINE":
+    return _winreg.HKEY_LOCAL_MACHINE
+  if key == "HKEY_USERS":
+    return _winreg.HKEY_USERS
+  raise Exception("Unknown registry key")
+
+
+def VerifyRegistryEntry(key, entry):
+  expected = entry["expected"]

[gab, 2013/07/31 13:45:16]

Does this raise an exception if "expected" hasn't been specified? It probably
should somehow fail given this is a mandatory value for registry entries.

[sukolsak, 2013/07/31 18:20:30]

Python will raise the KeyError exception when the key is not in the dictionary.

+  print settings.PRINT_VERIFIER_PREFIX + key,
+  if expected:
+    print "exists...",

[gab, 2013/07/31 13:45:16]

Don't these prints need the PRINT_VERIFIER_PREFIX as well?

[sukolsak, 2013/07/31 18:20:30]

No. I want it to be on the same line. The output will look like this:

- Verify that HKEY\a exists... Passed
- Verify that HKEY\b doesn't exist... Passed

[gab, 2013/08/01 20:30:41]

Ah ok my bad, assumed print forced an automatic new line.

+  else:
+    print "doesn't exist...",
+  try:
+    root_key, sub_key = key.split("\\", 1)
+    reg_key = _winreg.OpenKey(RootKeyConstant(root_key),
+        sub_key, 0, _winreg.KEY_READ)

[gab, 2013/07/31 13:45:16]

Indent to delimiter ('(') or 4 spaces in, not a mix of both, see
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Indent...

[sukolsak, 2013/07/31 18:20:30]

Done.

+    if expected == False:

[gab, 2013/07/31 13:45:16]

Doesn't

if !expected

work here?

[sukolsak, 2013/07/31 18:20:30]

Done.

+      return False
+    if "value" in entry:
+      # TODO(sukolsak): implement value
+      pass
+    return True
+  except WindowsError:
+    return expected == False

[gab, 2013/07/31 13:45:16]

!expected

? I don't know python much, can we not assume |expected| is a bool here perhaps
and thus need to do ==False?

[sukolsak, 2013/07/31 18:20:30]

Done.