chrome/test/mini_installer_test/data/config.config - Issue 20578004: Initial commit for the Automated Installer Testing Framework.

Side by Side Diff: chrome/test/mini_installer_test/data/config.config

Issue 20578004: Initial commit for the Automated Installer Testing Framework. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/mini_installer_test/data/chrome_installed.prop ('K') | « chrome/test/mini_installer_test/data/chrome_not_installed.prop ('k') | chrome/test/mini_installer_test/registry_verifier.py » ('j') | chrome/test/mini_installer_test/registry_verifier.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "states": [

	3 ["clean", ["chrome_not_installed.prop"]],

	4 ["chrome_installed", ["chrome_installed.prop"]]

	5 ],

	6 "actions": [

	7 ["install chrome", "mini_installer.exe --chrome --multi-install"],

	8 ["uninstall chrome", "mini_installer.exe --chrome --uninstall"]
	gab 2013/07/30 20:44:14 This should do the real uninstall imo, i.e. run wh This should do the real uninstall imo, i.e. run whatever Chrome registered as its uninstall command @ "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-AFF1-A69D9E530F96}\\(UninstallCommand + UninstallArguments)" Perhaps the command here should point to a script that knows how to do that. gab 2013/07/31 13:45:16 For now I'm fine with this being a script that doe Show quoted text On 2013/07/30 20:44:14, gab wrote: > This should do the real uninstall imo, i.e. run whatever Chrome registered as > its uninstall command @ > "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-AFF1-A69D9E530F96}\\(UninstallCommand > + UninstallArguments)" > > Perhaps the command here should point to a script that knows how to do that. For now I'm fine with this being a script that does the wrong thing with a TODO, e.g. uninstall.py: # TODO(sukolsak): This should read the uninstall command from the registry and run that instead. subprocess.call("mini_installer.exe --chrome --uninstall", Shell=True) I think the script will eventually need to take at least a product key (the product to be uninstalled); e.g., {8A69D345-D564-463c-AFF1-A69D9E530F96} so that it can read the proper uninstall command from the registry, but the above with a TODO should be roughly fine for this version (and then I guess the command in the config for now becomes "python uninstall.py"). Does that make sense? grt (UTC plus 2) 2013/07/31 17:20:05 Note that the command to run to uninstall the MSI Show quoted text On 2013/07/31 13:45:16, gab wrote: > On 2013/07/30 20:44:14, gab wrote: > > This should do the real uninstall imo, i.e. run whatever Chrome registered as > > its uninstall command @ > > > "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-AFF1-A69D9E530F96}\\(UninstallCommand > > + UninstallArguments)" > > > > Perhaps the command here should point to a script that knows how to do that. > > For now I'm fine with this being a script that does the wrong thing with a TODO, > e.g. uninstall.py: > > # TODO(sukolsak): This should read the uninstall command from the registry and > run that instead. > subprocess.call("mini_installer.exe --chrome --uninstall", Shell=True) > > > I think the script will eventually need to take at least a product key (the > product to be uninstalled); e.g., {8A69D345-D564-463c-AFF1-A69D9E530F96} so that > it can read the proper uninstall command from the registry, but the above with a > TODO should be roughly fine for this version (and then I guess the command in > the config for now becomes "python uninstall.py"). > > Does that make sense? Note that the command to run to uninstall the MSI is unrelated to the ordinary Chrome uninstall commands. If the infrastructure will (eventually) support installing/testing/uninstalling the MSI, then this needs to be taken into account somehow. grt (UTC plus 2) 2013/07/31 17:20:05 The correct uninstall command here is "--uninstall The correct uninstall command here is "--uninstall --multi-install --chrome" since the corresponding install command include "--multi-install". sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/31 13:45:16, gab wrote: > On 2013/07/30 20:44:14, gab wrote: > > This should do the real uninstall imo, i.e. run whatever Chrome registered as > > its uninstall command @ > > > "HKEY_CURRENT_USER\\Software\\Google\\Update\\Clients\\{8A69D345-D564-463c-AFF1-A69D9E530F96}\\(UninstallCommand > > + UninstallArguments)" > > > > Perhaps the command here should point to a script that knows how to do that. > > For now I'm fine with this being a script that does the wrong thing with a TODO, > e.g. uninstall.py: > > # TODO(sukolsak): This should read the uninstall command from the registry and > run that instead. > subprocess.call("mini_installer.exe --chrome --uninstall", Shell=True) > > > I think the script will eventually need to take at least a product key (the > product to be uninstalled); e.g., {8A69D345-D564-463c-AFF1-A69D9E530F96} so that > it can read the proper uninstall command from the registry, but the above with a > TODO should be roughly fine for this version (and then I guess the command in > the config for now becomes "python uninstall.py"). > > Does that make sense? Done. sukolsak 2013/07/31 18:20:30 Done. Show quoted text On 2013/07/31 17:20:05, grt (no reviews Aug 3-11) wrote: > The correct uninstall command here is "--uninstall --multi-install --chrome" > since the corresponding install command include "--multi-install". Done.
	9 ],

	10 "tests": [

	11 ["clean", "install chrome", "chrome_installed", "uninstall chrome", "clean"]

	12 ]

	13 }

OLD	NEW